-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8319323: FFM: Harmonize the @throws tags in the javadocs #16478
Conversation
👋 Welcome back pminborg! A progress list of the required criteria for merging this PR into |
Nice to see consistency, while respecting English grammar. |
@minborg This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 10 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit be01caf.
Your commit was automatically rebased without conflicts. |
This PR proposes to harmonize the @throws tags in the javadocs for the FFM API.
The @throws tags are using a bit different principles with respect to formatting and ending with a period or not.
Looking at some prominent Java classes like
List
andStream
, they:Some of the tags in the FFM classes already conform to these bullets. This PR proposes to make them all do.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16478/head:pull/16478
$ git checkout pull/16478
Update a local copy of the PR:
$ git checkout pull/16478
$ git pull https://git.openjdk.org/jdk.git pull/16478/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 16478
View PR using the GUI difftool:
$ git pr show -t 16478
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16478.diff
Webrev
Link to Webrev Comment