Skip to content

8241503: C2: Share MacroAssembler between mach nodes during code emission #16484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 14 commits into from
Closed

8241503: C2: Share MacroAssembler between mach nodes during code emission #16484

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
06a50bf
Reuse same C2_MacroAssembler object to emit instructions.
JohnTortugo Sep 30, 2023
b56c98d
Catch up with changes on master
JohnTortugo Nov 21, 2023
89a6dff
Some inst_mark fixes; Catch up with master.
JohnTortugo Nov 29, 2023
b239b24
Catch up with master branch.
JohnTortugo Nov 29, 2023
afe48fe
Fix merge
JohnTortugo Nov 29, 2023
d950806
Fix build, copyright dates, m4 files.
JohnTortugo Dec 5, 2023
1669279
Merge with origin/master
JohnTortugo Dec 14, 2023
23e64ce
Catch up with origin/master
JohnTortugo Jan 4, 2024
bea8c5a
Catching up with origin/master
JohnTortugo Jan 24, 2024
aa80c80
Catching up with changes in master
JohnTortugo Mar 22, 2024
e763b08
Fix AArch64 build & improve comment about InstructionMark
JohnTortugo Mar 22, 2024
b4d73c9
Merge remote-tracking branch 'origin/master' into reuse-macroasm
JohnTortugo Mar 26, 2024
693c7ef
Fix ARM32 AD file
JohnTortugo Apr 9, 2024
44e63ee
Remove unused operands in arm.ad
JohnTortugo Apr 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 21 additions & 9 deletions src/hotspot/cpu/arm/arm.ad
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1193,6 +1193,18 @@ bool maybe_far_call(const MachCallNode *n) {
// tertiary opcode. Only the opcode sections which a particular instruction
// needs for encoding need to be specified.
encode %{
// Set instruction mark in MacroAssembler. This is used only in
// instructions that emit bytes directly to the CodeBuffer wraped
// in the MacroAssembler. Should go away once all "instruct" are
// patched to emit bytes only using methods in MacroAssembler.
enc_class SetInstMark %{
__ set_inst_mark();
%}

enc_class ClearInstMark %{
__ clear_inst_mark();
%}

enc_class call_epilog %{
// nothing
%}
Expand Down Expand Up @@ -8853,7 +8865,7 @@ instruct CallStaticJavaDirect( method meth ) %{

ins_cost(CALL_COST);
format %{ "CALL,static ==> " %}
ins_encode( Java_Static_Call( meth ), call_epilog );
ins_encode( SetInstMark, Java_Static_Call( meth ), call_epilog, ClearInstMark );
ins_pipe(simple_call);
%}

Expand All @@ -8867,7 +8879,7 @@ instruct CallStaticJavaHandle( method meth ) %{

ins_cost(CALL_COST);
format %{ "CALL,static/MethodHandle ==> " %}
ins_encode( preserve_SP, Java_Static_Call( meth ), restore_SP, call_epilog );
ins_encode( SetInstMark, preserve_SP, Java_Static_Call( meth ), restore_SP, call_epilog, ClearInstMark );
ins_pipe(simple_call);
%}

Expand All @@ -8879,7 +8891,7 @@ instruct CallDynamicJavaDirect( method meth ) %{
ins_cost(CALL_COST);
format %{ "MOV_OOP (empty),R_R8\n\t"
"CALL,dynamic ; NOP ==> " %}
ins_encode( Java_Dynamic_Call( meth ), call_epilog );
ins_encode( SetInstMark, Java_Dynamic_Call( meth ), call_epilog, ClearInstMark );
ins_pipe(call);
%}

Expand All @@ -8889,8 +8901,8 @@ instruct CallRuntimeDirect(method meth) %{
effect(USE meth);
ins_cost(CALL_COST);
format %{ "CALL,runtime" %}
ins_encode( Java_To_Runtime( meth ),
call_epilog );
ins_encode( SetInstMark, Java_To_Runtime( meth ),
call_epilog, ClearInstMark );
ins_pipe(simple_call);
%}

Expand All @@ -8901,8 +8913,8 @@ instruct CallLeafDirect(method meth) %{
ins_cost(CALL_COST);
format %{ "CALL,runtime leaf" %}
// TODO: need save_last_PC here?
ins_encode( Java_To_Runtime( meth ),
call_epilog );
ins_encode( SetInstMark, Java_To_Runtime( meth ),
call_epilog, ClearInstMark );
ins_pipe(simple_call);
%}

Expand All @@ -8913,8 +8925,8 @@ instruct CallLeafNoFPDirect(method meth) %{
ins_cost(CALL_COST);
format %{ "CALL,runtime leaf nofp" %}
// TODO: need save_last_PC here?
ins_encode( Java_To_Runtime( meth ),
call_epilog );
ins_encode( SetInstMark, Java_To_Runtime( meth ),
call_epilog, ClearInstMark );
ins_pipe(simple_call);
%}

Expand Down