Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8257518: LogCompilation: java.lang.InternalError with JFR turned on #1649

Closed
wants to merge 1 commit into from

Conversation

@ericcaspole
Copy link

@ericcaspole ericcaspole commented Dec 6, 2020

…ing app with JFR turned on

JBS: https://bugs.openjdk.java.net/browse/JDK-8257518

I added a test case with JFR turned on that produces the same c2n as in the original case. Tested with 8, 11, and 15.
Thanks,
Eric


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8257518: LogCompilation: java.lang.InternalError with JFR turned on

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1649/head:pull/1649
$ git checkout pull/1649

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 6, 2020

👋 Welcome back ecaspole! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Dec 6, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 6, 2020

@ericcaspole The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 6, 2020

Webrevs

Loading

@ericcaspole ericcaspole changed the title 8257518: LogCompilation: throws java.lang.InternalError on short runn… 8257518: LogCompilation: java.lang.InternalError with JFR turned on Dec 8, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 8, 2020

@ericcaspole This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8257518: LogCompilation: java.lang.InternalError with JFR turned on

Reviewed-by: kvn, redestad

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 70 new commits pushed to the master branch:

  • 6c69eca: 8257973: UTIL_LOOKUP_PROGS should only find executable files
  • 6eff931: 8256950: Add record attribute support to symbol generator CreateSymbols
  • f148915: 8245107: Use Unified Logging in trace_method_handle_stub()
  • 0201a33: 8255959: Timeouts in VectorConversion tests
  • d3dddb6: 8256657: Add cross-compiled build for Windows+Arm64 to submit workflow
  • 616b1f1: 8257516: define test group for manual tests
  • 5bdce9b: 8257639: Update usage of "type" terminology in java.lang.Enum & java.lang.Record
  • b4615c6: 8256580: Fault in new grid display
  • df55ecd: 8257794: Zero: assert(istate->_stack_limit == istate->_thread->last_Java_sp() + 1) failed: wrong on Linux/x86_32
  • fae7961: 8257884: Re-enable sun/security/ssl/SSLSocketImpl/SSLSocketLeak.java as automatic test
  • ... and 60 more: https://git.openjdk.java.net/jdk/compare/c4339c3064190bd10fdba64f85a501a2f3d52685...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Dec 8, 2020
cl4es
cl4es approved these changes Dec 9, 2020
@ericcaspole
Copy link
Author

@ericcaspole ericcaspole commented Dec 9, 2020

/integrate

Loading

@openjdk openjdk bot closed this Dec 9, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 9, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 9, 2020

@ericcaspole Since your change was applied there have been 70 commits pushed to the master branch:

  • 6c69eca: 8257973: UTIL_LOOKUP_PROGS should only find executable files
  • 6eff931: 8256950: Add record attribute support to symbol generator CreateSymbols
  • f148915: 8245107: Use Unified Logging in trace_method_handle_stub()
  • 0201a33: 8255959: Timeouts in VectorConversion tests
  • d3dddb6: 8256657: Add cross-compiled build for Windows+Arm64 to submit workflow
  • 616b1f1: 8257516: define test group for manual tests
  • 5bdce9b: 8257639: Update usage of "type" terminology in java.lang.Enum & java.lang.Record
  • b4615c6: 8256580: Fault in new grid display
  • df55ecd: 8257794: Zero: assert(istate->_stack_limit == istate->_thread->last_Java_sp() + 1) failed: wrong on Linux/x86_32
  • fae7961: 8257884: Re-enable sun/security/ssl/SSLSocketImpl/SSLSocketLeak.java as automatic test
  • ... and 60 more: https://git.openjdk.java.net/jdk/compare/c4339c3064190bd10fdba64f85a501a2f3d52685...master

Your commit was automatically rebased without conflicts.

Pushed as commit cf62b0a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@ericcaspole ericcaspole deleted the JDK-8257518 branch Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants