Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8319379: G1: gc/logging/TestUnifiedLoggingSwitchStress.java crashes after JDK-8318894 #16495

Closed
wants to merge 1 commit into from

Conversation

albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Nov 3, 2023

Can reproduce the failure using TEST=gc/logging/TestUnifiedLoggingSwitchStress.java JTREG="REPEAT_COUNT=10", but not any more after the fix.

(The MIN2 was removed as part of JDK-8318894; added back now.)


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8319379: G1: gc/logging/TestUnifiedLoggingSwitchStress.java crashes after JDK-8318894 (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16495/head:pull/16495
$ git checkout pull/16495

Update a local copy of the PR:
$ git checkout pull/16495
$ git pull https://git.openjdk.org/jdk.git pull/16495/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16495

View PR using the GUI difftool:
$ git pr show -t 16495

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16495.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 3, 2023

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8319379 8319379: G1: gc/logging/TestUnifiedLoggingSwitchStress.java crashes after JDK-8318894 Nov 3, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 3, 2023
@openjdk
Copy link

openjdk bot commented Nov 3, 2023

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Nov 3, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 3, 2023

Webrevs

Copy link
Contributor

@tschatzl tschatzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Thanks for the quick turnaround!

@openjdk
Copy link

openjdk bot commented Nov 3, 2023

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8319379: G1: gc/logging/TestUnifiedLoggingSwitchStress.java crashes after JDK-8318894

Reviewed-by: tschatzl, sjohanss

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • b5c863b: 8316533: C2 compilation fails with assert(verify(phase)) failed: missing Value() optimization
  • 377138c: 8318959: C2: define MachNode::fill_new_machnode() statically
  • c146685: 8319165: hsdis binutils: warns on empty string as option string
  • 01c0d5d: 8319412: RISC-V: Simple fix of indent in c2_MacroAssembler_riscv.hpp
  • df599db: 8295159: DSO created with -ffast-math breaks Java floating-point arithmetic
  • c099cf5: 8318422: Allow poller threads be virtual threads
  • 29cf2c4: 8319053: Segment dump files remain after parallel heap dump on Windows
  • ea6a88a: 8318466: Improve spec of NumberFormat's methods with unsupported operations
  • de6667c: 8225377: type annotations are not visible to javac plugins across compilation boundaries
  • 008ca2a: 8317620: Build JDK tools with ModuleMainClass attribute

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 3, 2023
@albertnetymk
Copy link
Member Author

Thanks for the review.

/integrate

@openjdk
Copy link

openjdk bot commented Nov 6, 2023

Going to push as commit 8fb94fd.
Since your change was applied there have been 10 commits pushed to the master branch:

  • b5c863b: 8316533: C2 compilation fails with assert(verify(phase)) failed: missing Value() optimization
  • 377138c: 8318959: C2: define MachNode::fill_new_machnode() statically
  • c146685: 8319165: hsdis binutils: warns on empty string as option string
  • 01c0d5d: 8319412: RISC-V: Simple fix of indent in c2_MacroAssembler_riscv.hpp
  • df599db: 8295159: DSO created with -ffast-math breaks Java floating-point arithmetic
  • c099cf5: 8318422: Allow poller threads be virtual threads
  • 29cf2c4: 8319053: Segment dump files remain after parallel heap dump on Windows
  • ea6a88a: 8318466: Improve spec of NumberFormat's methods with unsupported operations
  • de6667c: 8225377: type annotations are not visible to javac plugins across compilation boundaries
  • 008ca2a: 8317620: Build JDK tools with ModuleMainClass attribute

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 6, 2023
@openjdk openjdk bot closed this Nov 6, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 6, 2023
@openjdk
Copy link

openjdk bot commented Nov 6, 2023

@albertnetymk Pushed as commit 8fb94fd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@albertnetymk albertnetymk deleted the g1-age-fix branch November 6, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
3 participants