Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253147: The javax/swing/JPopupMenu/7154841/bug7154841.java fail on big screens #165

Closed
wants to merge 1 commit into from

Conversation

@mrserb
Copy link
Member

@mrserb mrserb commented Sep 15, 2020

This test creates a big popup menu and assumes that 100 popup items overlap the screen height, but on some big screens more items should be added. + small cleanup


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8253147: The javax/swing/JPopupMenu/7154841/bug7154841.java fail on big screens

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/165/head:pull/165
$ git checkout pull/165

frame.pack();
frame.setLocationRelativeTo(null);
frame.setVisible(true);
Copy link
Member Author

@mrserb mrserb Sep 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was a "typo" to place the window to the center of the screen we need to pack/setSize/setBounds and then setLocationRelativeTo

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 15, 2020

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Sep 15, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 15, 2020

@mrserb The following labels will be automatically applied to this pull request: awt swing.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label (add|remove) "label" command.

@mrserb
Copy link
Member Author

@mrserb mrserb commented Sep 15, 2020

/label add client

@openjdk
Copy link

@openjdk openjdk bot commented Sep 15, 2020

@mrserb The label client is not a valid label. These labels are valid:

  • serviceability
  • hotspot
  • sound
  • hotspot-compiler
  • kulla
  • i18n
  • shenandoah
  • jdk
  • javadoc
  • 2d
  • security
  • swing
  • hotspot-runtime
  • jmx
  • build
  • nio
  • beans
  • core-libs
  • compiler
  • net
  • hotspot-gc
  • hotspot-jfr
  • awt

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 15, 2020

Webrevs

prrace
prrace approved these changes Sep 15, 2020
Copy link
Contributor

@prrace prrace left a comment

OK. Although

  1. Maybe 100->200 would have been enough
  2. it seems odd to throw the AlphaColorTest update in here too ..

@openjdk
Copy link

@openjdk openjdk bot commented Sep 15, 2020

@mrserb This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8253147: The javax/swing/JPopupMenu/7154841/bug7154841.java fail on big screens

Reviewed-by: prr
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 12 commits pushed to the master branch:

  • fc36328: 8253034: Update symbol generation to accomodate Git as the SCM
  • 4020682: 8172366: Support SHA-3 based signatures
  • 46598c8: 8253177: outputStream not declared in markWord.hpp
  • 5191f31: 8251495: Remove the implNote in the DOM package description added by JDK-8249643
  • 65d6c10: 8252933: com.sun.tools.jdi.ObjectReferenceImpl#validateAssignment always requests referenceType
  • 74851c5: 8253169: [BACKOUT] Improve large object handling during evacuation
  • b5620a3: 8253155: Minor cleanups and Javadoc fixes for LdapDnsProvider of java.naming
  • d219d8b: 8253002: Remove the unused SafePointNode::_oop_map field
  • dafcf10: 8027545: Improve object array chunking test in G1's copy_to_survivor_space
  • 7eb4d4a: 8247909: Improve PrimitiveConversions::cast using C++14
  • ... and 2 more: https://git.openjdk.java.net/jdk/compare/3f455f09dc738b7c76210c1080df2aaa8e19a19d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate fc36328d4f35627427f7352f5db6feb0e1e469f0.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 15, 2020
@mrserb
Copy link
Member Author

@mrserb mrserb commented Sep 15, 2020

OK. Although

  1. Maybe 100->200 would have been enough
  2. it seems odd to throw the AlphaColorTest update in here too ..

200 is not enough if the big display set vertically.

@mrserb
Copy link
Member Author

@mrserb mrserb commented Sep 15, 2020

/integrate

@openjdk openjdk bot closed this Sep 15, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 15, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 15, 2020

@mrserb Since your change was applied there have been 12 commits pushed to the master branch:

  • fc36328: 8253034: Update symbol generation to accomodate Git as the SCM
  • 4020682: 8172366: Support SHA-3 based signatures
  • 46598c8: 8253177: outputStream not declared in markWord.hpp
  • 5191f31: 8251495: Remove the implNote in the DOM package description added by JDK-8249643
  • 65d6c10: 8252933: com.sun.tools.jdi.ObjectReferenceImpl#validateAssignment always requests referenceType
  • 74851c5: 8253169: [BACKOUT] Improve large object handling during evacuation
  • b5620a3: 8253155: Minor cleanups and Javadoc fixes for LdapDnsProvider of java.naming
  • d219d8b: 8253002: Remove the unused SafePointNode::_oop_map field
  • dafcf10: 8027545: Improve object array chunking test in G1's copy_to_survivor_space
  • 7eb4d4a: 8247909: Improve PrimitiveConversions::cast using C++14
  • ... and 2 more: https://git.openjdk.java.net/jdk/compare/3f455f09dc738b7c76210c1080df2aaa8e19a19d...master

Your commit was automatically rebased without conflicts.

Pushed as commit 65bfe09.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb mrserb deleted the JDK-8253147 branch Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants