8315034 : File.mkdirs() occasionally fails to create folders on Windows shared folder #16502

weibxiao · 2023-11-03T18:11:10Z

File.mkdirs() occasionally fails to create folders on Windows shared folders. It turned out that Windows API FindFirstFileW created the error ERROR_NO_MORE_FILES. In some of the cases with a valid file path, this error still returns this error code, which supposedly should not.

Adding this error code into the method of lastErrorReportable in the native code will be handled by JDK.

To test the fix, it needs to run three Java processes to create the folders on a remote file server.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8315034: File.mkdirs() occasionally fails to create folders on Windows shared folder (Bug - P4)

Reviewers

Brian Burkhalter (@bplb - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16502/head:pull/16502
$ git checkout pull/16502

Update a local copy of the PR:
$ git checkout pull/16502
$ git pull https://git.openjdk.org/jdk.git pull/16502/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16502

View PR using the GUI difftool:
$ git pr show -t 16502

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16502.diff

Webrev

Link to Webrev Comment

…ws shared folder

bridgekeeper · 2023-11-03T18:12:15Z

👋 Welcome back weibxiao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2023-11-03T18:13:27Z

@weibxiao The following label will be automatically applied to this pull request:

core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

AlanBateman · 2023-11-04T12:39:10Z

test/jdk/java/io/File/WindowsFileCreation.java

+ *  With different the parameters in command line, the test should run successfully without failure. This test
+ *  needs to run three Java processes simultaneously to verify the fix.
+ *  This test requires to run manually and the parent folder as Windows shared folder should be existing already.
+ */


There's no @test tag so this test won't run, not even as a manual test. I would be inclined to just drop this test and add the "noreg-hard" label to the issue.

AlanBateman · 2023-11-05T09:40:00Z

src/java.base/windows/native/libjava/canonicalize_md.c

@@ -138,7 +138,8 @@ lastErrorReportable()
        || (errval == ERROR_BAD_NET_NAME)
        || (errval == ERROR_ACCESS_DENIED)
        || (errval == ERROR_NETWORK_UNREACHABLE)
-        || (errval == ERROR_NETWORK_ACCESS_DENIED)) {
+        || (errval == ERROR_NETWORK_ACCESS_DENIED)
+        || (errval == ERROR_NO_MORE_FILES)) {


@bplb Is this the same thing as JDK-8234363? Does this also need to be handled in the FindFirstFile usage in WindowsDirectoryStream?

It seems likely. I don't recall having been able to replicate these problems however.

I used to duplicate it quite easily on my personal laptop with JDK11 (one laptop with Windows 11, the other with Windows 10). After my laptop system got updated, it was almost impossible to recreate it with my two laptops. To verify this bug, we have to configure exactly the same testing environment as the customer was having.

weibxiao · 2023-11-30T14:15:41Z

Removed the test file and added the label to JBS

mlbridge · 2023-11-30T14:20:28Z

Webrevs

00: Full (5903a482)

openjdk · 2023-11-30T17:18:03Z

@weibxiao This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315034: File.mkdirs() occasionally fails to create folders on Windows shared folder

Reviewed-by: bpb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 512 new commits pushed to the master branch:

41daa3b: 8320239: add dynamic switch for JvmtiVTMSTransitionDisabler sync protocol
7c135c3: 8321066: Multiple JFR tests have started failing
8bedb28: 8321119: Disable java/foreign/TestHandshake.java on Zero VMs
b1cbf55: 8321018: Parallel: Make some methods in ParCompactionManager private
c6a8278: 8321127: ProblemList java/util/stream/GatherersTest.java
a3eb664: 8315701: [macos] Regression: KeyEvent has different keycode on different keyboard layouts
6aba6aa: 8320347: Emulate vblendvp[sd] on ECore
6938474: 8320916: jdk/jfr/event/gc/stacktrace/TestParallelMarkSweepAllocationPendingStackTrace.java failed with "OutOfMemoryError: GC overhead limit exceeded"
da09eab: 8319980: [JVMCI] libgraal should reuse Thread instances as C2 does
33b26f7: 8319123: Implement JEP 461: Stream Gatherers (Preview)
... and 502 more: https://git.openjdk.org/jdk/compare/bd22d2381fa3f21b113d5b8ef95fe15cec50b066...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@bplb) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

weibxiao · 2023-11-30T17:23:01Z

/integrate

openjdk · 2023-11-30T17:24:34Z

@weibxiao
Your change (at version 5903a48) is now ready to be sponsored by a Committer.

bplb · 2023-11-30T17:34:10Z

/sponsor

openjdk · 2023-11-30T17:34:52Z

Going to push as commit 7ad7005.
Since your change was applied there have been 512 commits pushed to the master branch:

41daa3b: 8320239: add dynamic switch for JvmtiVTMSTransitionDisabler sync protocol
7c135c3: 8321066: Multiple JFR tests have started failing
8bedb28: 8321119: Disable java/foreign/TestHandshake.java on Zero VMs
b1cbf55: 8321018: Parallel: Make some methods in ParCompactionManager private
c6a8278: 8321127: ProblemList java/util/stream/GatherersTest.java
a3eb664: 8315701: [macos] Regression: KeyEvent has different keycode on different keyboard layouts
6aba6aa: 8320347: Emulate vblendvp[sd] on ECore
6938474: 8320916: jdk/jfr/event/gc/stacktrace/TestParallelMarkSweepAllocationPendingStackTrace.java failed with "OutOfMemoryError: GC overhead limit exceeded"
da09eab: 8319980: [JVMCI] libgraal should reuse Thread instances as C2 does
33b26f7: 8319123: Implement JEP 461: Stream Gatherers (Preview)
... and 502 more: https://git.openjdk.org/jdk/compare/bd22d2381fa3f21b113d5b8ef95fe15cec50b066...master

Your commit was automatically rebased without conflicts.

openjdk · 2023-11-30T17:34:59Z

@bplb @weibxiao Pushed as commit 7ad7005.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

omasseau · 2024-07-11T13:10:32Z

Hello, Has this been backported to Java 8 ? I can't really find the info.

jaikiran · 2024-07-14T13:24:33Z

Hello Olivier, this has been backported to 11, 17 and 21 update releases but not to JDK 8. I don't closely follow the update releases, so I don't know if there's a reason for that.

bplb · 2024-07-18T18:41:17Z

Hello, Has this been backported to Java 8 ? I can't really find the info.

According to the issue JDK-8321863 it looks like it has been so backported.

weibxiao · 2024-07-18T19:16:03Z

It was not backport to jdk8u. https://bugs.openjdk.org/browse/JDK-8321863 is for 8u411-perf, which is not same as jdk8u release. The bug originally was reported in jdk11, not in jdk8. That’s the reason I did not backport the change to jdk8u. From: Brian Burkhalter ***@***.***> Date: Thursday, July 18, 2024 at 2:41 PM To: openjdk/jdk ***@***.***> Cc: Weibing Xiao ***@***.***>, Mention ***@***.***> Subject: [External] : Re: [openjdk/jdk] 8315034 : File.mkdirs() occasionally fails to create folders on Windows shared folder (PR #16502) Hello, Has this been backported to Java 8 ? I can't really find the info. According to the issue JDK-8321863<https://bugs.openjdk.org/browse/JDK-8321863> it looks like it has been so backported. — Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https:/github.com/openjdk/jdk/pull/16502*issuecomment-2237262955__;Iw!!ACWV5N9M2RV99hQ!PR2KjEjBmXU6E3-YKNOLy6jy2YB1Jw62HIhlGjb-fQ89qh4isQZVzbCbcjG-E9OSqjtmIyl6v3T9sPnktnn5mN-1l2w$>, or unsubscribe<https://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AP4PT5FJ7OUTZFDXWI3ZECDZNAD6JAVCNFSM6AAAAABKW6VHHCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZXGI3DEOJVGU__;!!ACWV5N9M2RV99hQ!PR2KjEjBmXU6E3-YKNOLy6jy2YB1Jw62HIhlGjb-fQ89qh4isQZVzbCbcjG-E9OSqjtmIyl6v3T9sPnktnn5NbZaCuI$>. You are receiving this because you were mentioned.Message ID: ***@***.***>

bplb · 2024-07-18T19:21:03Z

It was not backport to jdk8u. https://bugs.openjdk.org/browse/JDK-8321863 is for 8u411-perf, which is not same as jdk8u release.

Thanks for the clarification.

8315034 : File.mkdirs() occasionally fails to create folders on Windo…

960ec8d

…ws shared folder

openjdk bot added the core-libs core-libs-dev@openjdk.org label Nov 3, 2023

AlanBateman reviewed Nov 4, 2023

View reviewed changes

AlanBateman reviewed Nov 5, 2023

View reviewed changes

remove test file

5903a48

weibxiao marked this pull request as ready for review November 30, 2023 14:16

openjdk bot added the rfr Pull request is ready for review label Nov 30, 2023

bplb approved these changes Nov 30, 2023

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Nov 30, 2023

openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 30, 2023

openjdk bot added the integrated Pull request has been integrated label Nov 30, 2023

openjdk bot closed this Nov 30, 2023

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 30, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8315034 : File.mkdirs() occasionally fails to create folders on Windows shared folder #16502

8315034 : File.mkdirs() occasionally fails to create folders on Windows shared folder #16502

weibxiao commented Nov 3, 2023 •

edited by openjdk bot

Loading

bridgekeeper bot commented Nov 3, 2023

openjdk bot commented Nov 3, 2023

AlanBateman Nov 4, 2023

AlanBateman Nov 5, 2023

bplb Nov 6, 2023

weibxiao Nov 8, 2023

weibxiao commented Nov 30, 2023

mlbridge bot commented Nov 30, 2023

openjdk bot commented Nov 30, 2023

weibxiao commented Nov 30, 2023

openjdk bot commented Nov 30, 2023

bplb commented Nov 30, 2023

openjdk bot commented Nov 30, 2023

openjdk bot commented Nov 30, 2023

omasseau commented Jul 11, 2024 •

edited by bridgekeeper bot

Loading

jaikiran commented Jul 14, 2024

bplb commented Jul 18, 2024

weibxiao commented Jul 18, 2024 via email

bplb commented Jul 18, 2024

8315034 : File.mkdirs() occasionally fails to create folders on Windows shared folder #16502

8315034 : File.mkdirs() occasionally fails to create folders on Windows shared folder #16502

Conversation

weibxiao commented Nov 3, 2023 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

Webrev

bridgekeeper bot commented Nov 3, 2023

openjdk bot commented Nov 3, 2023

AlanBateman Nov 4, 2023

Choose a reason for hiding this comment

AlanBateman Nov 5, 2023

Choose a reason for hiding this comment

bplb Nov 6, 2023

Choose a reason for hiding this comment

weibxiao Nov 8, 2023

Choose a reason for hiding this comment

weibxiao commented Nov 30, 2023

mlbridge bot commented Nov 30, 2023

Webrevs

openjdk bot commented Nov 30, 2023

weibxiao commented Nov 30, 2023

openjdk bot commented Nov 30, 2023

bplb commented Nov 30, 2023

openjdk bot commented Nov 30, 2023

openjdk bot commented Nov 30, 2023

omasseau commented Jul 11, 2024 • edited by bridgekeeper bot Loading

jaikiran commented Jul 14, 2024

bplb commented Jul 18, 2024

weibxiao commented Jul 18, 2024 via email

bplb commented Jul 18, 2024

weibxiao commented Nov 3, 2023 •

edited by openjdk bot

Loading

omasseau commented Jul 11, 2024 •

edited by bridgekeeper bot

Loading