JDK-8319413: Start of release updates for JDK 23 #16505

jddarcy · 2023-11-03T23:42:03Z

Time to start making preparations for JDK 23.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change requires CSR request JDK-8319428 to be approved
Change requires CSR request JDK-8319426 to be approved
Change must not contain extraneous whitespace
Commit message must refer to an issue
Change requires CSR request JDK-8319427 to be approved

Issues

JDK-8319413: Start of release updates for JDK 23 (Bug - P4)
JDK-8319414: Add SourceVersion.RELEASE_23 (Sub-task - P4)
JDK-8319416: Add source 23 and target 23 to javac (Sub-task - P4)
JDK-8319428: Start of release updates for JDK 23 (CSR)
JDK-8319427: Add SourceVersion.RELEASE_23 (CSR)
JDK-8319426: Add source 23 and target 23 to javac (CSR)

Reviewers

Iris Clark (@irisclark - Reviewer) ⚠️ Review applies to 2ee6cb96
Erik Joelsson (@erikj79 - Reviewer) ⚠️ Review applies to a0bc033d
Alan Bateman (@AlanBateman - Reviewer) ⚠️ Review applies to 9daf1014
Vicente Romero (@vicente-romero-oracle - Reviewer) ⚠️ Review applies to 9daf1014

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16505/head:pull/16505
$ git checkout pull/16505

Update a local copy of the PR:
$ git checkout pull/16505
$ git pull https://git.openjdk.org/jdk.git pull/16505/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16505

View PR using the GUI difftool:
$ git pr show -t 16505

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16505.diff

Webrev

Link to Webrev Comment

jddarcy · 2023-11-03T23:43:27Z

/issue add JDK-8319414

jddarcy · 2023-11-03T23:43:55Z

/issue add JDK-8319416

bridgekeeper · 2023-11-03T23:52:11Z

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2023-11-03T23:53:13Z

@jddarcy
Adding additional issue to issue list: 8319414: Add SourceVersion.RELEASE_23.

src/java.base/share/classes/jdk/internal/classfile/Classfile.java

openjdk · 2023-11-03T23:54:10Z

@jddarcy
Adding additional issue to issue list: 8319416: Add source 23 and target 23 to javac.

openjdk · 2023-11-03T23:54:57Z

@jddarcy The following labels will be automatically applied to this pull request:

build
compiler
core-libs
hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

jddarcy · 2023-11-27T18:42:30Z

Nothing exception in this batch of start-of-release updates. Clean local testing results on tier 1.

The symbol files correspond to JDK 22 build 25 and will be updated with subsequent builds as usual.

mlbridge · 2023-11-27T18:45:24Z

Webrevs

openjdk · 2023-11-27T22:44:12Z

@jddarcy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8319413: Start of release updates for JDK 23
8319414: Add SourceVersion.RELEASE_23
8319416: Add source 23 and target 23 to javac

Reviewed-by: iris, erikj, alanb, vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

dholmes-ora

Hotspot change is trivially fine, but too insignificant to hit the Approve button.

Thanks

erikj79

Build changes look good.

jddarcy · 2023-12-02T20:31:45Z

Looks good. I assume you'll bump the copyright header on the files that need it before integration, e.g. JavacTestingAbstractProcessor.

Right; I run a script to update the years of modified files.

turbanoff · 2023-12-02T20:40:57Z

test/langtools/tools/javac/versions/Versions.java

@@ -93,6 +94,7 @@ static enum SourceTarget {
        TWENTY(false,    "64.0", "20"),
        TWENTY_ONE(false,"65.0", "21"),
        TWENTY_TWO(false,"66.0", "22"),
+        TWENTY_THREE(false,"67.0", "23"),


As alignment is broken anyway, let's add space

Suggested change

TWENTY_THREE(false,"67.0", "23"),

TWENTY_THREE(false, "67.0", "23"),

If you're going to add the space, I'd consider establishing new alignment at TWENTY to accommodate the eventual space needed for "THREE", "SEVEN", and "EIGHT". You wouldn't need to reset alignment for quite some time after that.

irisclark · 2023-12-05T05:37:11Z

test/langtools/tools/javac/versions/Versions.java

@@ -93,6 +94,7 @@ static enum SourceTarget {
        TWENTY(false,    "64.0", "20"),
        TWENTY_ONE(false,"65.0", "21"),
        TWENTY_TWO(false,"66.0", "22"),
+        TWENTY_THREE(false,"67.0", "23"),


If you're going to add the space, I'd consider establishing new alignment at TWENTY to accommodate the eventual space needed for "THREE", "SEVEN", and "EIGHT". You wouldn't need to reset alignment for quite some time after that.

jddarcy · 2023-12-07T06:40:25Z

/integrate delegate

openjdk · 2023-12-07T06:41:33Z

@jddarcy Integration of this pull request has been delegated and may be completed by any project committer using the /integrate pull request command.

JesperIRL · 2023-12-07T17:00:04Z

/integrate

openjdk · 2023-12-07T17:01:32Z

Going to push as commit 519ecd3.
Since your change was applied there have been 17 commits pushed to the master branch:

86f9b3f: 8319313: G1: Rename G1EvacFailureInjector appropriately
a7f6016: 8320370: NMT: Change MallocMemorySnapshot to simplify code.
58530f4: 8321223: Implementation of Scoped Values (Second Preview)
2f9e70e: 8321001: RISC-V: C2 SignumVF
de95259: 8316454: JFR break locale settings
c42535f: 8321470: ThreadLocal.nextHashCode can be static final
42bb852: 8321467: MemorySegment.setString(long, String, Charset) throws IAE(Misaligned access)
c087e91: 8321505: JFR: Update views
ead4fb1: 8321519: Typo in exception message
b5933b1: 8320805: JFR: Create view for deprecated methods
... and 7 more: https://git.openjdk.org/jdk/compare/632a3c56e0626b4c4f79c8cb3d2ae312668d63fc...master

Your commit was automatically rebased without conflicts.

openjdk · 2023-12-07T17:01:40Z

@JesperIRL Pushed as commit 519ecd3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

JDK-8319413: Start of release updates for JDK 23

6d6d756

jddarcy marked this pull request as draft November 3, 2023 23:42

openjdk bot added the csr Pull request needs approved CSR before integration label Nov 3, 2023

liach suggested changes Nov 3, 2023

View reviewed changes

src/java.base/share/classes/jdk/internal/classfile/Classfile.java Outdated Show resolved Hide resolved

openjdk bot added hotspot-runtime hotspot-runtime-dev@openjdk.org build build-dev@openjdk.org core-libs core-libs-dev@openjdk.org compiler compiler-dev@openjdk.org labels Nov 3, 2023

Fix omission in Classfile.java

388e9c7

openjdk bot removed the csr Pull request needs approved CSR before integration label Nov 8, 2023

jddarcy added 4 commits November 8, 2023 12:43

Adjust expected release date.

2e78b39

Merge branch 'master' into JDK-8319413

2b594de

Merge branch 'master' into JDK-8319413

dea26cc

Add symbol files for JDK 22 build 25.

a0bc033

jddarcy marked this pull request as ready for review November 27, 2023 18:40

openjdk bot added the rfr Pull request is ready for review label Nov 27, 2023

irisclark approved these changes Nov 27, 2023

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Nov 27, 2023

dholmes-ora reviewed Nov 28, 2023

View reviewed changes

erikj79 approved these changes Nov 28, 2023

View reviewed changes

Merge branch 'master' into JDK-8319413

49c5ef6

jddarcy added 2 commits December 1, 2023 12:40

Merge branch 'master' into JDK-8319413

4330d5e

Merge branch 'master' into JDK-8319413

703ea1a

Merge branch 'master' into JDK-8319413

77ea0f0

turbanoff reviewed Dec 2, 2023

View reviewed changes

lahodaj mentioned this pull request Dec 3, 2023

8321224: ct.sym for JDK 22 contains references to internal modules #16942

Closed

4 tasks

jddarcy added 3 commits December 4, 2023 09:22

Merge branch 'master' into JDK-8319413

aba9b9a

Add symbol files.

727dd13

Merge branch 'master' into JDK-8319413

2ee6cb9

irisclark approved these changes Dec 5, 2023

View reviewed changes

jddarcy added 7 commits December 4, 2023 23:58

Merge branch 'master' into JDK-8319413

77e3230

Merge branch 'master' into JDK-8319413

96b2f78

Regenerate JDK 22 symbol files.

efe849f

Merge branch 'master' into JDK-8319413

68d5bd1

Merge branch 'master' into JDK-8319413

ac3598c

Merge branch 'master' into JDK-8319413

4a87137

Update copyright year.

a1aa187

openjdk bot added the delegated label Dec 7, 2023

openjdk bot added the integrated Pull request has been integrated label Dec 7, 2023

openjdk bot closed this Dec 7, 2023

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review delegated labels Dec 7, 2023

ice1000 mentioned this pull request Jan 28, 2024

Re-porting Class-File API Glavo/classfile#14

Closed

jddarcy deleted the JDK-8319413 branch October 27, 2024 18:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

JDK-8319413: Start of release updates for JDK 23 #16505

JDK-8319413: Start of release updates for JDK 23 #16505

jddarcy commented Nov 3, 2023 •

edited by openjdk bot

Loading

jddarcy commented Nov 3, 2023

jddarcy commented Nov 3, 2023

bridgekeeper bot commented Nov 3, 2023

openjdk bot commented Nov 3, 2023

openjdk bot commented Nov 3, 2023

openjdk bot commented Nov 3, 2023

jddarcy commented Nov 27, 2023

mlbridge bot commented Nov 27, 2023 •

edited

Loading

openjdk bot commented Nov 27, 2023 •

edited

Loading

dholmes-ora left a comment

erikj79 left a comment

jddarcy commented Dec 2, 2023

turbanoff Dec 2, 2023

irisclark Dec 5, 2023

irisclark Dec 5, 2023

jddarcy commented Dec 7, 2023

openjdk bot commented Dec 7, 2023

JesperIRL commented Dec 7, 2023

openjdk bot commented Dec 7, 2023

openjdk bot commented Dec 7, 2023

	TWENTY_THREE(false,"67.0", "23"),
	TWENTY_THREE(false, "67.0", "23"),

JDK-8319413: Start of release updates for JDK 23 #16505

JDK-8319413: Start of release updates for JDK 23 #16505

Conversation

jddarcy commented Nov 3, 2023 • edited by openjdk bot Loading

Progress

Issues

Reviewers

Reviewing

Webrev

jddarcy commented Nov 3, 2023

jddarcy commented Nov 3, 2023

bridgekeeper bot commented Nov 3, 2023

openjdk bot commented Nov 3, 2023

openjdk bot commented Nov 3, 2023

openjdk bot commented Nov 3, 2023

jddarcy commented Nov 27, 2023

mlbridge bot commented Nov 27, 2023 • edited Loading

Webrevs

openjdk bot commented Nov 27, 2023 • edited Loading

dholmes-ora left a comment

Choose a reason for hiding this comment

erikj79 left a comment

Choose a reason for hiding this comment

jddarcy commented Dec 2, 2023

turbanoff Dec 2, 2023

Choose a reason for hiding this comment

irisclark Dec 5, 2023

Choose a reason for hiding this comment

irisclark Dec 5, 2023

Choose a reason for hiding this comment

jddarcy commented Dec 7, 2023

openjdk bot commented Dec 7, 2023

JesperIRL commented Dec 7, 2023

openjdk bot commented Dec 7, 2023

openjdk bot commented Dec 7, 2023

jddarcy commented Nov 3, 2023 •

edited by openjdk bot

Loading

mlbridge bot commented Nov 27, 2023 •

edited

Loading

openjdk bot commented Nov 27, 2023 •

edited

Loading