8319444: Unhelpful failure output in TestLegalNotices

[cushon]

Please consider this fix for JDK-8319444: Unhelpful failure output in TestLegalNotices, which improves test output for failing subtests.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8319444: Unhelpful failure output in TestLegalNotices (Bug - P4)

Reviewers

• Hannes Wallnöfer (@hns - Reviewer)
• Jonathan Gibbons (@jonathan-gibbons - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16507/head:pull/16507
$ git checkout pull/16507

Update a local copy of the PR:
$ git checkout pull/16507
$ git pull https://git.openjdk.org/jdk.git pull/16507/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16507

View PR using the GUI difftool:
$ git pr show -t 16507

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16507.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back cushon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@cushon The following label will be automatically applied to this pull request:

• javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (ea6fbce2)

[hns]

Looks good!

[openjdk]

@cushon This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8319444: Unhelpful failure output in TestLegalNotices

Reviewed-by: hannesw, jjg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 308 new commits pushed to the master branch:

• a2c5f1f: 8319417: (dc) DatagramChannel.connect undocumented behavior
• abf2e49: 8320859: gtest high malloc footprint caused by BufferNodeAllocator stress test
• 033cced: 8320368: Per-CPU optimization of Klass range reservation
• 48960df: 8316734: URLEncoder should specify that replacement bytes will be used in case of coding error
• 1594653: 8310644: Make panama memory segment close use async handshakes
• 65dfcae: 8308399: Recommend --release when -source and -target are misused
• 335f5db: 8320911: RISC-V: Enable hotspot/jtreg/compiler/intrinsics/chacha/TestChaCha20.java
• 77d604a: 8319373: Serial: Refactor dirty cards scanning during Young GC
• 38cfb22: 8318706: Implement JEP 423: Region Pinning for G1
• e44d4b2: 8320858: Move jpackage tests to tier3
• ... and 298 more: https://git.openjdk.org/jdk/compare/df599dbb9b0f0ee96d1ec767ac8821f164ab075d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[cushon]

/integrate

[openjdk]

Going to push as commit 62418c6.
Since your change was applied there have been 314 commits pushed to the master branch:

• cdd1a6e: 8313816: Accessing jmethodID might lead to spurious crashes
• b65ccff: 8320877: Shenandoah: Remove ShenandoahUnloadClassesFrequency support
• b68356b: 8320806: Augment test/langtools/tools/javac/versions/Versions.java for JDK 22 language changes
• d783aa3: 8320940: Fix typo in java.lang.Double
• 43c7f6a: 8320907: Shenandoah: Remove ShenandoahSelfFixing flag
• da7bcfc: 8319935: Ensure only one JvmtiThreadState is created for one JavaThread associated with attached native thread
• a2c5f1f: 8319417: (dc) DatagramChannel.connect undocumented behavior
• abf2e49: 8320859: gtest high malloc footprint caused by BufferNodeAllocator stress test
• 033cced: 8320368: Per-CPU optimization of Klass range reservation
• 48960df: 8316734: URLEncoder should specify that replacement bytes will be used in case of coding error
• ... and 304 more: https://git.openjdk.org/jdk/compare/df599dbb9b0f0ee96d1ec767ac8821f164ab075d...master

Your commit was automatically rebased without conflicts.

[openjdk]

@cushon Pushed as commit 62418c6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.