Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8319450: Add missing @since tags for new ofLiteral() methods #16510

Closed
wants to merge 1 commit into from

Conversation

marchof
Copy link
Member

@marchof marchof commented Nov 5, 2023


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Integration blocker

 ⚠️ Title mismatch between PR and JBS for issue JDK-8319450

Issue

  • JDK-8319450: New methods java.net.InetXAddress.ofLiteral() miss @since tag (Bug - P4) ⚠️ Title mismatch between PR and JBS.

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16510/head:pull/16510
$ git checkout pull/16510

Update a local copy of the PR:
$ git checkout pull/16510
$ git pull https://git.openjdk.org/jdk.git pull/16510/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16510

View PR using the GUI difftool:
$ git pr show -t 16510

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16510.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 5, 2023

👋 Welcome back marchof! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 5, 2023

@marchof The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added net net-dev@openjdk.org rfr Pull request is ready for review labels Nov 5, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 5, 2023

Webrevs

@marchof
Copy link
Member Author

marchof commented Nov 5, 2023

No idea why I closed this. Looks like I can't re-open. Will give another try. Sry.

@djelinski
Copy link
Member

For future reference, bot command /open would probably help.

@erikj79
Copy link
Member

erikj79 commented Nov 6, 2023

It looks like you pushed something weird. Github is unable to show the diff, and shows over 5000 changed files. The bot can't find a merge-base between the source and target.

@marchof
Copy link
Member Author

marchof commented Nov 7, 2023

@djelinski @erikj79 Thanks for your help! As always the problem is in front of the screen :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
net net-dev@openjdk.org rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

3 participants