JDK-8319455: Test compiler/print/CompileCommandMemLimit.java times out

[tstuefe]

A test that deliberately crashes creates a core dump, and since neither heap size is limited nor core dumps are switched off this timeouts if we are unlucky.

Solution: pass CreateCoreDumpOnCrash to the test and limit heap size too. Thanks to @dholmes-ora for the quick analysis.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8319455: Test compiler/print/CompileCommandMemLimit.java times out (Bug - P3)

Reviewers

• Tobias Hartmann (@TobiHartmann - Reviewer)
• Christian Hagedorn (@chhagedorn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16515/head:pull/16515
$ git checkout pull/16515

Update a local copy of the PR:
$ git checkout pull/16515
$ git pull https://git.openjdk.org/jdk.git pull/16515/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16515

View PR using the GUI difftool:
$ git pr show -t 16515

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16515.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tstuefe The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[tstuefe]

mac os test error unrelated

[mlbridge]

Webrevs

• 00: Full (2219b353)

[TobiHartmann]

Looks good to me.

[openjdk]

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8319455: Test compiler/print/CompileCommandMemLimit.java times out

Reviewed-by: thartmann, chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

• 1c2ea1d: 8319153: Fix: Class is a raw type in ProcessTools
• 96e6e67: 4365952: Cannot disable JFileChooser
• 2d4bbf4: 8319465: Typos in javadoc of com.sun.management.OperatingSystemMXBean methods
• 8fb94fd: 8319379: G1: gc/logging/TestUnifiedLoggingSwitchStress.java crashes after JDK-8318894
• b5c863b: 8316533: C2 compilation fails with assert(verify(phase)) failed: missing Value() optimization
• 377138c: 8318959: C2: define MachNode::fill_new_machnode() statically

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[chhagedorn]

Looks good!

[tstuefe]

Thanks @TobiHartmann and @chhagedorn !

/integrate

[openjdk]

Going to push as commit b3126b6.
Since your change was applied there have been 6 commits pushed to the master branch:

• 1c2ea1d: 8319153: Fix: Class is a raw type in ProcessTools
• 96e6e67: 4365952: Cannot disable JFileChooser
• 2d4bbf4: 8319465: Typos in javadoc of com.sun.management.OperatingSystemMXBean methods
• 8fb94fd: 8319379: G1: gc/logging/TestUnifiedLoggingSwitchStress.java crashes after JDK-8318894
• b5c863b: 8316533: C2 compilation fails with assert(verify(phase)) failed: missing Value() optimization
• 377138c: 8318959: C2: define MachNode::fill_new_machnode() statically

Your commit was automatically rebased without conflicts.

[openjdk]

@tstuefe Pushed as commit b3126b6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.