-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8319525: RISC-V: Rename *_riscv64.ad files to *_riscv.ad under riscv/gc #16521
Conversation
👋 Welcome back fjiang! A progress list of the required criteria for merging this PR into |
@feilongjiang The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
/label remove shenandoah, hotspot |
@feilongjiang The |
@feilongjiang Unknown command |
/label add hotspot-compiler |
@feilongjiang |
@feilongjiang This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 13 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
@luhenry @RealFYang -- Thanks! |
Going to push as commit b2504a0.
Your commit was automatically rebased without conflicts. |
@feilongjiang Pushed as commit b2504a0. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi, please review this trivial patch that renames
*_riscv64.ad
files to*_riscv.ad
.In the early development at jdk-sandbox, there was a commit [1] that renamed all filenames from riscv64 to riscv, but some
.ad
files underriscv/gc
were missed.Testing
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16521/head:pull/16521
$ git checkout pull/16521
Update a local copy of the PR:
$ git checkout pull/16521
$ git pull https://git.openjdk.org/jdk.git pull/16521/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 16521
View PR using the GUI difftool:
$ git pr show -t 16521
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16521.diff
Webrev
Link to Webrev Comment