Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8319525: RISC-V: Rename *_riscv64.ad files to *_riscv.ad under riscv/gc #16521

Closed

Conversation

feilongjiang
Copy link
Member

@feilongjiang feilongjiang commented Nov 6, 2023

Hi, please review this trivial patch that renames *_riscv64.ad files to *_riscv.ad.
In the early development at jdk-sandbox, there was a commit [1] that renamed all filenames from riscv64 to riscv, but some .ad files under riscv/gc were missed.

  1. openjdk/jdk-sandbox@5500685

Testing

  • release build
  • hotspot:tier1

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8319525: RISC-V: Rename *_riscv64.ad files to *_riscv.ad under riscv/gc (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16521/head:pull/16521
$ git checkout pull/16521

Update a local copy of the PR:
$ git checkout pull/16521
$ git pull https://git.openjdk.org/jdk.git pull/16521/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16521

View PR using the GUI difftool:
$ git pr show -t 16521

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16521.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 6, 2023

👋 Welcome back fjiang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 6, 2023
@openjdk
Copy link

openjdk bot commented Nov 6, 2023

@feilongjiang The following labels will be automatically applied to this pull request:

  • hotspot
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot hotspot-dev@openjdk.org shenandoah shenandoah-dev@openjdk.org labels Nov 6, 2023
@feilongjiang
Copy link
Member Author

feilongjiang commented Nov 6, 2023

/label remove shenandoah, hotspot

@openjdk openjdk bot removed shenandoah shenandoah-dev@openjdk.org hotspot hotspot-dev@openjdk.org labels Nov 6, 2023
@openjdk
Copy link

openjdk bot commented Nov 6, 2023

@feilongjiang
The shenandoah label was successfully removed.

The hotspot label was successfully removed.

@openjdk
Copy link

openjdk bot commented Nov 6, 2023

@feilongjiang Unknown command lable - for a list of valid commands use /help.

@feilongjiang
Copy link
Member Author

/label add hotspot-compiler

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Nov 6, 2023
@openjdk
Copy link

openjdk bot commented Nov 6, 2023

@feilongjiang
The hotspot-compiler label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Nov 6, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 7, 2023

@feilongjiang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8319525: RISC-V: Rename *_riscv64.ad files to *_riscv.ad under riscv/gc

Reviewed-by: luhenry, fyang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

  • 439ed04: 8319233: AArch64: Build failure with clang due to -Wformat-nonliteral warning
  • e4803e0: 8318580: "javax/swing/MultiMonitor/MultimonVImage.java failing with Error. Can't find library: /open/test/jdk/java/awt/regtesthelpers" after JDK-8316053
  • cdf3373: 8319316: Clarify text around which layouts a linker supports
  • 1696603: 8308453: Convert JKS test keystores in test/jdk/javax/net/ssl/etc to PKCS12
  • b3126b6: 8319455: Test compiler/print/CompileCommandMemLimit.java times out
  • 1c2ea1d: 8319153: Fix: Class is a raw type in ProcessTools
  • 96e6e67: 4365952: Cannot disable JFileChooser
  • 2d4bbf4: 8319465: Typos in javadoc of com.sun.management.OperatingSystemMXBean methods
  • 8fb94fd: 8319379: G1: gc/logging/TestUnifiedLoggingSwitchStress.java crashes after JDK-8318894
  • b5c863b: 8316533: C2 compilation fails with assert(verify(phase)) failed: missing Value() optimization
  • ... and 3 more: https://git.openjdk.org/jdk/compare/df599dbb9b0f0ee96d1ec767ac8821f164ab075d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 7, 2023
@feilongjiang
Copy link
Member Author

@luhenry @RealFYang -- Thanks!
/integrate

@openjdk
Copy link

openjdk bot commented Nov 7, 2023

Going to push as commit b2504a0.
Since your change was applied there have been 26 commits pushed to the master branch:

  • bfafb27: 8319615: IGV incomplete gitignore
  • c760097: 8319541: G1: Inline G1RemoveSelfForwardsTask into RestoreRetainedRegionsTask
  • 85e4cde: 8319620: Parallel: Remove unused PSPromotionManager::*_is_full getters and setters
  • d22e368: 8319462: Signature.ClassTypeSig::classDesc() incorrect for inner class types
  • 541ff71: 8318144: Match on enum constants with body compiles but fails with MatchException
  • 42f43c5: 8319563: Reformat code in the FFM API
  • ac0ee20: 8319613: Complier error in benchmark TestLoadSegmentVarious
  • a7c0190: 8319238: JMX ThreadPoolAccTest.java is too verbose and should fail before timeout
  • 9ac6ac8: 8319559: [JVMCI] ensureLinked must be able to call Java
  • 1c0e7b7: 8319408: RISC-V: MaxVectorSize is not consistently checked in several situations
  • ... and 16 more: https://git.openjdk.org/jdk/compare/df599dbb9b0f0ee96d1ec767ac8821f164ab075d...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 7, 2023
@openjdk openjdk bot closed this Nov 7, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 7, 2023
@openjdk
Copy link

openjdk bot commented Nov 7, 2023

@feilongjiang Pushed as commit b2504a0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@feilongjiang feilongjiang deleted the fix_riscv_file_name branch November 7, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
3 participants