8319436: Proxy.newProxyInstance throws NPE if loader is null and interface not visible from class loader

[mlchung]

This is a regression caused by JDK-8302791. IAE should be thrown when an interface is not visible to the given class loader but NPE is thrown instead when the loader is null. The boot loader has no name and so the fix will print null in the exception message. test/jdk/java/lang/reflect/Proxy/ClassRestrictions.java is converted to junit and updated to test IAE thrown because proxy interface is not visible to null loader.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8319436: Proxy.newProxyInstance throws NPE if loader is null and interface not visible from class loader (Bug - P3)

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16525/head:pull/16525
$ git checkout pull/16525

Update a local copy of the PR:
$ git checkout pull/16525
$ git pull https://git.openjdk.org/jdk.git pull/16525/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16525

View PR using the GUI difftool:
$ git pr show -t 16525

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16525.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mchung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mlchung The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (4be40b5d)
• 00: Full (5fef84a4)

[AlanBateman]

The fix to getLoaderNameID looks fine, the update and conversion of the test looks okay too.

[openjdk]

@mlchung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8319436: Proxy.newProxyInstance throws NPE if loader is null and interface not visible from class loader

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• 419ed90: 8319450: New methods java.net.InetXAddress.ofLiteral() miss @SInCE tag
• 439ed04: 8319233: AArch64: Build failure with clang due to -Wformat-nonliteral warning
• e4803e0: 8318580: "javax/swing/MultiMonitor/MultimonVImage.java failing with Error. Can't find library: /open/test/jdk/java/awt/regtesthelpers" after JDK-8316053

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlchung]

/integrate

[openjdk]

Going to push as commit 8eb6f61.
Since your change was applied there have been 23 commits pushed to the master branch:

• 8274713: 8314891: Additional Zip64 extra header validation
• 0dcd730: 8318594: NMT: VM.native_memory crashes on assert if functionality isn't supported by OS
• 45e68ae: 8319532: jshell - Non-sealed declarations sometimes break a snippet evaluation
• 4a0ad46: 8317937: @sealedGraph: Links to inner classes fails in links
• 134c382: 8319560: Reformat method parameters in the FFM API
• ef8c840: 8319607: FFM: Review the language in the FFM documentation
• bf9a93d: 8319204: G1: Change G1CMTask::_termination_time_ms to wallclock time
• b2504a0: 8319525: RISC-V: Rename *_riscv64.ad files to *_riscv.ad under riscv/gc
• bfafb27: 8319615: IGV incomplete gitignore
• c760097: 8319541: G1: Inline G1RemoveSelfForwardsTask into RestoreRetainedRegionsTask
• ... and 13 more: https://git.openjdk.org/jdk/compare/cdf337357a62dd52c00e56e75912565e15b6adfd...master

Your commit was automatically rebased without conflicts.

[openjdk]

@mlchung Pushed as commit 8eb6f61.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.