-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8319560: Reformat method parameters in the FFM API #16527
Conversation
👋 Welcome back pminborg! A progress list of the required criteria for merging this PR into |
@minborg This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/integrate |
@minborg Since your change was applied there have been 10 commits pushed to the
It was not possible to rebase your changes automatically. Please merge |
/integrate |
Going to push as commit 134c382. |
This PR proposes to reformat some method parameters in the FFM API. The proposed changes are a bit opinion based eve though there are some underlying principles.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16527/head:pull/16527
$ git checkout pull/16527
Update a local copy of the PR:
$ git checkout pull/16527
$ git pull https://git.openjdk.org/jdk.git pull/16527/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 16527
View PR using the GUI difftool:
$ git pr show -t 16527
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16527.diff
Webrev
Link to Webrev Comment