Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8319559: [JVMCI] ensureLinked must be able to call Java #16530

Closed
wants to merge 1 commit into from

Conversation

dougxc
Copy link
Member

@dougxc dougxc commented Nov 6, 2023

As of JDK-8318694, only a few select C2V entry points in jvmciCompilerToVM.cpp can make Java calls. The ensureLinked method was not included but needs to be as it is called from a Truffle context executing on a Compiler thread.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8319559: [JVMCI] ensureLinked must be able to call Java (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16530/head:pull/16530
$ git checkout pull/16530

Update a local copy of the PR:
$ git checkout pull/16530
$ git pull https://git.openjdk.org/jdk.git pull/16530/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16530

View PR using the GUI difftool:
$ git pr show -t 16530

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16530.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 6, 2023

👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 6, 2023
@openjdk
Copy link

openjdk bot commented Nov 6, 2023

@dougxc The following labels will be automatically applied to this pull request:

  • graal
  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added graal graal-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org labels Nov 6, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 6, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 6, 2023

@dougxc This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8319559: [JVMCI] ensureLinked must be able to call Java

Reviewed-by: never, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 1c0e7b7: 8319408: RISC-V: MaxVectorSize is not consistently checked in several situations
  • 74f1889: 8318678: Vector access on heap MemorySegments only works for byte[]
  • e1cae72: 8319197: Exclude hb-subset and hb-style from compilation
  • 419ed90: 8319450: New methods java.net.InetXAddress.ofLiteral() miss @SInCE tag
  • 439ed04: 8319233: AArch64: Build failure with clang due to -Wformat-nonliteral warning

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 6, 2023
@TobiHartmann
Copy link
Member

Looks good to me.

@dougxc
Copy link
Member Author

dougxc commented Nov 7, 2023

Thanks for the reviews.

/integrate

@openjdk
Copy link

openjdk bot commented Nov 7, 2023

Going to push as commit 9ac6ac8.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 1c0e7b7: 8319408: RISC-V: MaxVectorSize is not consistently checked in several situations
  • 74f1889: 8318678: Vector access on heap MemorySegments only works for byte[]
  • e1cae72: 8319197: Exclude hb-subset and hb-style from compilation
  • 419ed90: 8319450: New methods java.net.InetXAddress.ofLiteral() miss @SInCE tag
  • 439ed04: 8319233: AArch64: Build failure with clang due to -Wformat-nonliteral warning

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 7, 2023
@openjdk openjdk bot closed this Nov 7, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 7, 2023
@openjdk
Copy link

openjdk bot commented Nov 7, 2023

@dougxc Pushed as commit 9ac6ac8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dougxc dougxc deleted the JDK-8319559 branch August 20, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
graal graal-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants