-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8319615: IGV incomplete gitignore #16538
Conversation
👋 Welcome back dlunde! A progress list of the required criteria for merging this PR into |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this, Daniel, I tried it out locally and it gives a clean git status
output after building and running IGV. The fix is trivial, but please remove the extra line break before integrating.
@dlunde This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 62 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@robcasloz) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
/sponsor |
Going to push as commit bfafb27.
Your commit was automatically rebased without conflicts. |
@robcasloz @dlunde Pushed as commit bfafb27. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This changeset adds a number of IGV-generated files to the IGV
.gitignore
.Testing
No testing as there are no code changes.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16538/head:pull/16538
$ git checkout pull/16538
Update a local copy of the PR:
$ git checkout pull/16538
$ git pull https://git.openjdk.org/jdk.git pull/16538/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 16538
View PR using the GUI difftool:
$ git pr show -t 16538
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16538.diff
Webrev
Link to Webrev Comment