Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8319615: IGV incomplete gitignore #16538

Closed
wants to merge 2 commits into from

Conversation

dlunde
Copy link
Member

@dlunde dlunde commented Nov 7, 2023

This changeset adds a number of IGV-generated files to the IGV .gitignore.

Testing

No testing as there are no code changes.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8319615: IGV incomplete gitignore (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16538/head:pull/16538
$ git checkout pull/16538

Update a local copy of the PR:
$ git checkout pull/16538
$ git pull https://git.openjdk.org/jdk.git pull/16538/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16538

View PR using the GUI difftool:
$ git pr show -t 16538

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16538.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 7, 2023

👋 Welcome back dlunde! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8319615 8319615: IGV incomplete gitignore Nov 7, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 7, 2023
@openjdk
Copy link

openjdk bot commented Nov 7, 2023

@dlunde The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Nov 7, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 7, 2023

Webrevs

Copy link
Contributor

@robcasloz robcasloz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this, Daniel, I tried it out locally and it gives a clean git status output after building and running IGV. The fix is trivial, but please remove the extra line break before integrating.

src/utils/IdealGraphVisualizer/.gitignore Outdated Show resolved Hide resolved
@openjdk
Copy link

openjdk bot commented Nov 7, 2023

@dlunde This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8319615: IGV incomplete gitignore

Reviewed-by: rcastanedalo

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 62 new commits pushed to the master branch:

  • c760097: 8319541: G1: Inline G1RemoveSelfForwardsTask into RestoreRetainedRegionsTask
  • 85e4cde: 8319620: Parallel: Remove unused PSPromotionManager::*_is_full getters and setters
  • d22e368: 8319462: Signature.ClassTypeSig::classDesc() incorrect for inner class types
  • 541ff71: 8318144: Match on enum constants with body compiles but fails with MatchException
  • 42f43c5: 8319563: Reformat code in the FFM API
  • ac0ee20: 8319613: Complier error in benchmark TestLoadSegmentVarious
  • a7c0190: 8319238: JMX ThreadPoolAccTest.java is too verbose and should fail before timeout
  • 9ac6ac8: 8319559: [JVMCI] ensureLinked must be able to call Java
  • 1c0e7b7: 8319408: RISC-V: MaxVectorSize is not consistently checked in several situations
  • 74f1889: 8318678: Vector access on heap MemorySegments only works for byte[]
  • ... and 52 more: https://git.openjdk.org/jdk/compare/d354141aa191c80b473dfeee27b51f1562ffeafd...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@robcasloz) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 7, 2023
@dlunde
Copy link
Member Author

dlunde commented Nov 7, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 7, 2023
@openjdk
Copy link

openjdk bot commented Nov 7, 2023

@dlunde
Your change (at version 9495df0) is now ready to be sponsored by a Committer.

@robcasloz
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 7, 2023

Going to push as commit bfafb27.
Since your change was applied there have been 62 commits pushed to the master branch:

  • c760097: 8319541: G1: Inline G1RemoveSelfForwardsTask into RestoreRetainedRegionsTask
  • 85e4cde: 8319620: Parallel: Remove unused PSPromotionManager::*_is_full getters and setters
  • d22e368: 8319462: Signature.ClassTypeSig::classDesc() incorrect for inner class types
  • 541ff71: 8318144: Match on enum constants with body compiles but fails with MatchException
  • 42f43c5: 8319563: Reformat code in the FFM API
  • ac0ee20: 8319613: Complier error in benchmark TestLoadSegmentVarious
  • a7c0190: 8319238: JMX ThreadPoolAccTest.java is too verbose and should fail before timeout
  • 9ac6ac8: 8319559: [JVMCI] ensureLinked must be able to call Java
  • 1c0e7b7: 8319408: RISC-V: MaxVectorSize is not consistently checked in several situations
  • 74f1889: 8318678: Vector access on heap MemorySegments only works for byte[]
  • ... and 52 more: https://git.openjdk.org/jdk/compare/d354141aa191c80b473dfeee27b51f1562ffeafd...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 7, 2023
@openjdk openjdk bot closed this Nov 7, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 7, 2023
@openjdk
Copy link

openjdk bot commented Nov 7, 2023

@robcasloz @dlunde Pushed as commit bfafb27.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dlunde dlunde deleted the igv-gitignore-8319615 branch November 7, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants