New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8257805: Add compiler/blackhole tests to tier1 #1654
Conversation
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
Ping? I would like to have it in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is reasonable. It adds 21 tests and about 1 min to tier1_compiler_1 which currently takes less time than tier1_compiler_2 and tier1_compiler_3.
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 21 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Thank you! /integrate |
@shipilev Since your change was applied there have been 21 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 36c0600. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
JDK-8252505 added new tests. They are short, and were supposed to run in tier1. Unfortunately, they are in
compiler/blackhole
directory, not incompiler/c1
orcompiler/c2
, which would get them included into tier1 automatically. So, we need to include them to tier1 directly.Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/1654/head:pull/1654
$ git checkout pull/1654