Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8319253: [BACKOUT] Change LockingMode default from LM_LEGACY to LM_LIGHTWEIGHT #16551

Closed

Conversation

dholmes-ora
Copy link
Member

@dholmes-ora dholmes-ora commented Nov 8, 2023

The change of default locking mode for JDK 22 is being restored to LM_LEGACY due to remaining stability and performance issues that have been uncovered with lightweight locking, for which solutions have not yet been found, but are being actively investigated. We will make the change in JDK 23 instead.

This reverts commit 455cfae.

Testing: tiers 1-3 (our internal tier 3 testing includes a set of tests using mode LM_LIGHTWEIGHT so that it will continue to experience some testing until we flip things back in December)

Thanks.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8319253: [BACKOUT] Change LockingMode default from LM_LEGACY to LM_LIGHTWEIGHT (Sub-task - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16551/head:pull/16551
$ git checkout pull/16551

Update a local copy of the PR:
$ git checkout pull/16551
$ git pull https://git.openjdk.org/jdk.git pull/16551/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16551

View PR using the GUI difftool:
$ git pr show -t 16551

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16551.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 8, 2023

👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 8, 2023
@openjdk
Copy link

openjdk bot commented Nov 8, 2023

@dholmes-ora The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Nov 8, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 8, 2023

Webrevs

Copy link
Member

@tstuefe tstuefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable if regrettable.

@openjdk
Copy link

openjdk bot commented Nov 8, 2023

@dholmes-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8319253: [BACKOUT] Change LockingMode default from LM_LEGACY to LM_LIGHTWEIGHT

Reviewed-by: stuefe, shade, stefank, dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • 7c7f8ea: 8319456: jdk/jfr/event/gc/collection/TestGCCauseWith[Serial|Parallel].java : GC cause 'GCLocker Initiated GC' not in the valid causes
  • 7bc8e4c: 8294980: test/jdk/java/lang/invoke 15 test classes use experimental bytecode library
  • e841897: 8319374: JFR: Remove instrumentation for exception events
  • cd9719b: 8319306: Serial: Remove TenuredSpace::verify
  • 1e687b4: 8316719: C2 compilation still fails with "bad AD file"
  • 8555e0f: 8319318: bufferedStream fixed case can be removed
  • 73c5f60: 8319556: Harmonize interface formatting in the FFM API

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 8, 2023
Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The revert looks good.

Copy link
Member

@dcubed-ojdk dcubed-ojdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thumbs up. This is a trivial fix.

@dholmes-ora
Copy link
Member Author

Thanks for all the reviews!

/integrate

@openjdk
Copy link

openjdk bot commented Nov 8, 2023

Going to push as commit f4ab952.
Since your change was applied there have been 13 commits pushed to the master branch:

  • c137b17: 8187655: jdk.lambda.vm.InterfaceAccessFlagsTest.testPrivateMethodCall needs update after nestmates support
  • fa331d7: 8319184: RISC-V: improve MD5 intrinsic
  • 4c0f6c6: 8311961: Update Manual Test Groups for ATR JDK22
  • a6785e4: 8318915: Enhance checks in BigDecimal.toPlainString()
  • 7d25f1c: 8319423: Improve Year.isLeap by checking divisibility by 16
  • 59e9981: 8319376: ParallelGC: Forwarded objects found during heap inspection
  • 7c7f8ea: 8319456: jdk/jfr/event/gc/collection/TestGCCauseWith[Serial|Parallel].java : GC cause 'GCLocker Initiated GC' not in the valid causes
  • 7bc8e4c: 8294980: test/jdk/java/lang/invoke 15 test classes use experimental bytecode library
  • e841897: 8319374: JFR: Remove instrumentation for exception events
  • cd9719b: 8319306: Serial: Remove TenuredSpace::verify
  • ... and 3 more: https://git.openjdk.org/jdk/compare/cc4b0d9217ed27a9555dc82f0a4247bf9b703f2b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 8, 2023
@openjdk openjdk bot closed this Nov 8, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 8, 2023
@openjdk
Copy link

openjdk bot commented Nov 8, 2023

@dholmes-ora Pushed as commit f4ab952.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dholmes-ora dholmes-ora deleted the 8319253-backout-locking branch November 8, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
5 participants