JDK-8319704: LogTagSet::set_output_level() should not accept NULL as LogOutput by tstuefe · Pull Request #16555 · openjdk/jdk

tstuefe · 2023-11-08T11:00:35Z

Trivial change to add an assert.

See JDK-8319104

LogTagSet::set_output_level() and LogOutputList::set_output_level should not accept NULL as LogOutput* argument.

They do, currently, which leads to delayed crashes later since the NULL output is registered in the output list.

That triggered JDK-8319104, where - due to a fluke in C++ initialization order and a mislabeling of LogTagSet tests as "TEST", without "_VM" - LogTagSet::set_output_level() was called with LogConfiguration::StdoutLog which was still uninitialized (null).

An assert would have saved investigation time.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8319704: LogTagSet::set_output_level() should not accept NULL as LogOutput (Bug - P4)

Reviewers

Johan Sjölen (@jdksjolen - Reviewer) ⚠️ Review applies to f942134a
David Holmes (@dholmes-ora - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16555/head:pull/16555
$ git checkout pull/16555

Update a local copy of the PR:
$ git checkout pull/16555
$ git pull https://git.openjdk.org/jdk.git pull/16555/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16555

View PR using the GUI difftool:
$ git pr show -t 16555

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16555.diff

Webrev

Link to Webrev Comment

…utput

bridgekeeper · 2023-11-08T11:01:25Z

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2023-11-08T11:02:08Z

@tstuefe The following label will be automatically applied to this pull request:

hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

jdksjolen

LGTM.

jdksjolen · 2023-11-08T11:41:21Z

src/hotspot/share/logging/logOutputList.cpp

 }

 void LogOutputList::set_output_level(LogOutput* output, LogLevelType level) {
+  assert(output != nullptr, "LogOutput is NULL");


HotSpot comment and logging style is for nullptr to be printed as "null"

jdksjolen · 2023-11-08T11:41:54Z

Oops, apparently this is a draft, sorry about that.

tstuefe · 2023-11-10T11:38:35Z

Oops, apparently this is a draft, sorry about that.

No problem, and thanks! It still counts ... :)

openjdk · 2023-11-10T11:39:02Z

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8319704: LogTagSet::set_output_level() should not accept NULL as LogOutput

Reviewed-by: jsjolen, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 38 new commits pushed to the master branch:

50f41d6: 8309893: Integrate ReplicateB/S/I/L/F/D nodes to Replicate node
caf7181: 8318189: ChoiceFormat::format throws undocumented AIOOBE
9938b3f: 8319314: NMT detail report slow or hangs for large number of mappings
c9077b8: 8319339: Internal error on spurious markup in a hybrid snippet
ea1ffa3: 8318895: Deoptimization results in incorrect lightweight locking stack
c9657ca: 8319882: SequenceLayout::toString throws ArithmeticException
6b21ff6: 8319828: runtime/NMT/VirtualAllocCommitMerge.java may fail if mixing interpreted and compiled native invocations
a64fc48: 8319174: Enhance robustness of some j.m.BigInteger constructors
9cce9fe: 8319256: Print more diagnostic information when an unexpected user is found in a Phi
a95062b: 8319670: Improve comments describing system properties for TLS server and client for max chain length
... and 28 more: https://git.openjdk.org/jdk/compare/8555e0f6c40c045f7763777a9bf976de99c0534c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

mlbridge · 2023-11-10T11:42:05Z

Webrevs

01: Full - Incremental (dffb264b)
00: Full (f942134a)

tstuefe · 2023-11-10T12:09:25Z

@jdksjolen would you agree this is Trivial?

jdksjolen

Trivial change, integrate it!

jdksjolen · 2023-11-10T12:15:04Z

(but please change from "NULL" to "null")

dholmes-ora

LGTM

tstuefe · 2023-11-13T08:28:34Z

/integrate

openjdk · 2023-11-13T08:31:11Z

Going to push as commit 4d650fe.
Since your change was applied there have been 40 commits pushed to the master branch:

6f863b2: 8318636: Add jcmd to print annotated process memory map
e035637: 8319375: test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineLeakThrowable.java runs into OutOfMemoryError: Metaspace on AIX
50f41d6: 8309893: Integrate ReplicateB/S/I/L/F/D nodes to Replicate node
caf7181: 8318189: ChoiceFormat::format throws undocumented AIOOBE
9938b3f: 8319314: NMT detail report slow or hangs for large number of mappings
c9077b8: 8319339: Internal error on spurious markup in a hybrid snippet
ea1ffa3: 8318895: Deoptimization results in incorrect lightweight locking stack
c9657ca: 8319882: SequenceLayout::toString throws ArithmeticException
6b21ff6: 8319828: runtime/NMT/VirtualAllocCommitMerge.java may fail if mixing interpreted and compiled native invocations
a64fc48: 8319174: Enhance robustness of some j.m.BigInteger constructors
... and 30 more: https://git.openjdk.org/jdk/compare/8555e0f6c40c045f7763777a9bf976de99c0534c...master

Your commit was automatically rebased without conflicts.

openjdk · 2023-11-13T08:31:20Z

@tstuefe Pushed as commit 4d650fe.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

JDK-8319704-LogTagSet-set_output_level-should-not-accept-NULL-as-LogO…

f942134

…utput

openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Nov 8, 2023

jdksjolen approved these changes Nov 8, 2023

View reviewed changes

tstuefe marked this pull request as ready for review November 10, 2023 11:38

openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 10, 2023

jdksjolen approved these changes Nov 10, 2023

View reviewed changes

Update logOutputList.cpp

dffb264

dholmes-ora approved these changes Nov 13, 2023

View reviewed changes

openjdk bot added the integrated Pull request has been integrated label Nov 13, 2023

openjdk bot closed this Nov 13, 2023

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 13, 2023

Conversation

tstuefe commented Nov 8, 2023 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Webrev

Uh oh!

bridgekeeper bot commented Nov 8, 2023

Uh oh!

openjdk bot commented Nov 8, 2023

Uh oh!

jdksjolen left a comment

Choose a reason for hiding this comment

Uh oh!

jdksjolen Nov 8, 2023

Choose a reason for hiding this comment

Uh oh!

jdksjolen commented Nov 8, 2023

Uh oh!

tstuefe commented Nov 10, 2023

Uh oh!

openjdk bot commented Nov 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mlbridge bot commented Nov 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

tstuefe commented Nov 10, 2023

Uh oh!

jdksjolen left a comment

Choose a reason for hiding this comment

Uh oh!

jdksjolen commented Nov 10, 2023

Uh oh!

dholmes-ora left a comment

Choose a reason for hiding this comment

Uh oh!

tstuefe commented Nov 13, 2023

Uh oh!

openjdk bot commented Nov 13, 2023

Uh oh!

openjdk bot commented Nov 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

tstuefe commented Nov 8, 2023 •

edited by openjdk bot

Loading

openjdk bot commented Nov 10, 2023 •

edited

Loading

mlbridge bot commented Nov 10, 2023 •

edited

Loading