Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8319748: [JVMCI] TestUseCompressedOopsFlagsWithUlimit.java crashes on libgraal #16571

Closed
wants to merge 2 commits into from

Conversation

dougxc
Copy link
Member

@dougxc dougxc commented Nov 8, 2023

The memory allocated in libjvmci for the error message describing a failure in JNI_CreateJavaVM must not be freed with os::free as the allocation was not NMT-aware.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8319748: [JVMCI] TestUseCompressedOopsFlagsWithUlimit.java crashes on libgraal (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16571/head:pull/16571
$ git checkout pull/16571

Update a local copy of the PR:
$ git checkout pull/16571
$ git pull https://git.openjdk.org/jdk.git pull/16571/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16571

View PR using the GUI difftool:
$ git pr show -t 16571

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16571.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 8, 2023

👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 8, 2023

@dougxc Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 8, 2023
@openjdk
Copy link

openjdk bot commented Nov 8, 2023

@dougxc The following labels will be automatically applied to this pull request:

  • graal
  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added graal graal-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org labels Nov 8, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 8, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 8, 2023

@dougxc This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8319748: [JVMCI] TestUseCompressedOopsFlagsWithUlimit.java crashes on libgraal

Reviewed-by: never, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • a26f7c0: 6928542: Chinese characters in RTF are not decoded
  • 4e8c036: 8319665: [macOS] Obsolete imports of <Carbon/Carbon.h> in java.desktop

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 8, 2023
Copy link
Member

@TobiHartmann TobiHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@dougxc
Copy link
Member Author

dougxc commented Nov 9, 2023

Thanks for the reviews.

/integrate

@openjdk
Copy link

openjdk bot commented Nov 9, 2023

Going to push as commit 4451a92.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 7d8adfa: 8316746: Top of lock-stack does not match the unlocked object
  • dd9eab1: 8310886: C2 SuperWord: Two nodes should be isomorphic if they are loop invariant but pinned at different nodes outside the loop
  • 7e4cb2f: 8318962: Update ProcessTools javadoc with suggestions in 8315097
  • 0b58bde: 8319104: GtestWrapper crashes with SIGILL in AsyncLogTest::test_asynclog_raw on AIX opt
  • b0fc808: 8319725: G1: Subtracting virtual time from wall time after JDK-8319204
  • a26f7c0: 6928542: Chinese characters in RTF are not decoded
  • 4e8c036: 8319665: [macOS] Obsolete imports of <Carbon/Carbon.h> in java.desktop

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 9, 2023
@openjdk openjdk bot closed this Nov 9, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 9, 2023
@openjdk
Copy link

openjdk bot commented Nov 9, 2023

@dougxc Pushed as commit 4451a92.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
graal graal-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
3 participants