Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8319574: Exec/process tests should be marked as flagless #16572

Closed

Conversation

RogerRiggs
Copy link
Contributor

@RogerRiggs RogerRiggs commented Nov 8, 2023

Tests that directly use ProcessBuilder to spawn processes and do not pass the standard test command line arguments should be marked as vm.flagless to indicate to the testing infrastructure that they do not accept them and should not be run with extra test command line options test.vm.opts and test.java.opts.

Add @requires vm.flagless to tests


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8319574: Exec/process tests should be marked as flagless (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16572/head:pull/16572
$ git checkout pull/16572

Update a local copy of the PR:
$ git checkout pull/16572
$ git pull https://git.openjdk.org/jdk.git pull/16572/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16572

View PR using the GUI difftool:
$ git pr show -t 16572

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16572.diff

Webrev

Link to Webrev Comment

@RogerRiggs RogerRiggs marked this pull request as ready for review November 8, 2023 21:05
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 8, 2023

👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 8, 2023
@openjdk
Copy link

openjdk bot commented Nov 8, 2023

@RogerRiggs The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Nov 8, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 8, 2023

Webrevs

Copy link
Member

@bplb bplb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable.

@openjdk
Copy link

openjdk bot commented Nov 8, 2023

@RogerRiggs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8319574: Exec/process tests should be marked as flagless

Reviewed-by: bpb, naoto, jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • a26f7c0: 6928542: Chinese characters in RTF are not decoded
  • 4e8c036: 8319665: [macOS] Obsolete imports of <Carbon/Carbon.h> in java.desktop
  • f4ab952: 8319253: [BACKOUT] Change LockingMode default from LM_LEGACY to LM_LIGHTWEIGHT
  • c137b17: 8187655: jdk.lambda.vm.InterfaceAccessFlagsTest.testPrivateMethodCall needs update after nestmates support
  • fa331d7: 8319184: RISC-V: improve MD5 intrinsic
  • 4c0f6c6: 8311961: Update Manual Test Groups for ATR JDK22
  • a6785e4: 8318915: Enhance checks in BigDecimal.toPlainString()

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 8, 2023
Copy link
Member

@naotoj naotoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Member

@jaikiran jaikiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look OK to me.

It wasn't clear to me what "flagless" meant. I checked the implementation of how this @requires is implemented https://github.com/openjdk/jdk/blob/master/test/jtreg-ext/requires/VMProps.java#L657. So essentially, the definition of "flagless" comes down to "was the JVM in which jtreg is running and about to launch a test, launched using certain set of JVM arguments? If it wasn't launched with those set of JVM arguments, then it is flagless." The set of such JVM arguments appears to be wide and may change over time.

@dholmes-ora
Copy link
Member

dholmes-ora commented Nov 9, 2023

@jaikiran "flagless" should mean that jtreg was not launched with -javaoption or -vmoption being set. But I see now (thanks for the link) it does allow for some flags to be set <sigh>

@RogerRiggs
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 9, 2023

Going to push as commit 68110b7.
Since your change was applied there have been 17 commits pushed to the master branch:

  • 7b971c1: 8319705: RISC-V: signumF/D intrinsics fails compiler/intrinsics/math/TestSignumIntrinsic.java
  • f939542: 8319324: FFM: Reformat javadocs
  • a3f1b33: 8319664: IGV always output on PhaseRemoveUseless
  • f57b78c: 8319726: Parallel GC: Re-use object in object-iterator
  • 4451a92: 8319748: [JVMCI] TestUseCompressedOopsFlagsWithUlimit.java crashes on libgraal
  • 7d8adfa: 8316746: Top of lock-stack does not match the unlocked object
  • dd9eab1: 8310886: C2 SuperWord: Two nodes should be isomorphic if they are loop invariant but pinned at different nodes outside the loop
  • 7e4cb2f: 8318962: Update ProcessTools javadoc with suggestions in 8315097
  • 0b58bde: 8319104: GtestWrapper crashes with SIGILL in AsyncLogTest::test_asynclog_raw on AIX opt
  • b0fc808: 8319725: G1: Subtracting virtual time from wall time after JDK-8319204
  • ... and 7 more: https://git.openjdk.org/jdk/compare/7d25f1c6cb770e21cfad8096c1637a24e65fab8c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 9, 2023
@openjdk openjdk bot closed this Nov 9, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 9, 2023
@openjdk
Copy link

openjdk bot commented Nov 9, 2023

@RogerRiggs Pushed as commit 68110b7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
5 participants