Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8318759: Add four DigiCert root certificates #16574

Closed
wants to merge 1 commit into from
Closed

8318759: Add four DigiCert root certificates #16574

wants to merge 1 commit into from

Conversation

rhalade
Copy link
Member

@rhalade rhalade commented Nov 8, 2023

This PR is to add 4 new TLS root certificates from Digicert, Inc. This CA has gone through https://www.oracle.com/java/technologies/javase/carootcertsprogram.html process.

The release-note is at JDK-8319243


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8318759: Add four DigiCert root certificates (Enhancement - P2)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16574/head:pull/16574
$ git checkout pull/16574

Update a local copy of the PR:
$ git checkout pull/16574
$ git pull https://git.openjdk.org/jdk.git pull/16574/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16574

View PR using the GUI difftool:
$ git pr show -t 16574

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16574.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 8, 2023

👋 Welcome back rhalade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 8, 2023
@openjdk
Copy link

openjdk bot commented Nov 8, 2023

@rhalade The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Nov 8, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 8, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 14, 2023

@rhalade This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8318759: Add four DigiCert root certificates

Reviewed-by: mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 54 new commits pushed to the master branch:

  • 9c98270: 8254693: Add Panama feature to pass heap segments to native code
  • c80e691: 8319970: AArch64: enable tests compiler/intrinsics/Test(Long|Integer)UnsignedDivMod.java on aarch64
  • 856c280: 8319960: RISC-V: compiler/intrinsics/TestInteger/LongUnsignedDivMod.java failed with "counts: Graph contains wrong number of nodes"
  • cb7875d: 8318218: RISC-V: C2 CompressBits
  • 1535528: 8318479: [jmh] the test security.CacheBench failed for multiple threads run
  • 95bd92a: 8210807: Printing a JTable with a JScrollPane prints table without rows populated
  • 21cda19: 8309203: C2: remove copy-by-value of GrowableArray for InterfaceSet
  • b120a05: 8319406: x86: Shorter movptr(reg, imm) for 32-bit immediates
  • 7df73a2: 8318817: Could not reserve enough space in CodeHeap 'profiled nmethods' (0K)
  • 07eaea8: 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test
  • ... and 44 more: https://git.openjdk.org/jdk/compare/7d25f1c6cb770e21cfad8096c1637a24e65fab8c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 14, 2023
@rhalade
Copy link
Member Author

rhalade commented Nov 14, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Nov 14, 2023

Going to push as commit 0ea5804.
Since your change was applied there have been 60 commits pushed to the master branch:

  • 6a75c24: 8319958: test/jdk/java/io/File/libGetXSpace.c does not compile on Windows 32-bit
  • 58af9ae: 8316392: compiler/interpreter/TestVerifyStackAfterDeopt.java failed with SIGBUS in PcDescContainer::find_pc_desc_internal
  • a75b6e5: 8191460: crash in Annotate with duplicate declaration and annotation processing enabled
  • 7bb1999: 8316342: CLHSDB "dumpclass" command produces invalid classes
  • 97ea5bf: 8319961: JvmtiEnvBase doesn't zero _ext_event_callbacks
  • 25f9af9: 8319883: Zero: Use atomic built-ins for 64-bit accesses
  • 9c98270: 8254693: Add Panama feature to pass heap segments to native code
  • c80e691: 8319970: AArch64: enable tests compiler/intrinsics/Test(Long|Integer)UnsignedDivMod.java on aarch64
  • 856c280: 8319960: RISC-V: compiler/intrinsics/TestInteger/LongUnsignedDivMod.java failed with "counts: Graph contains wrong number of nodes"
  • cb7875d: 8318218: RISC-V: C2 CompressBits
  • ... and 50 more: https://git.openjdk.org/jdk/compare/7d25f1c6cb770e21cfad8096c1637a24e65fab8c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 14, 2023
@openjdk openjdk bot closed this Nov 14, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 14, 2023
@rhalade rhalade deleted the 8318759-digicert branch November 14, 2023 17:29
@openjdk
Copy link

openjdk bot commented Nov 14, 2023

@rhalade Pushed as commit 0ea5804.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
2 participants