Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8225220: When the Tab Policy is checked,the scroll button direction displayed incorrectly. #16601

Closed
wants to merge 2 commits into from
Closed

8225220: When the Tab Policy is checked,the scroll button direction displayed incorrectly. #16601

wants to merge 2 commits into from

Conversation

kumarabhi006
Copy link
Contributor

@kumarabhi006 kumarabhi006 commented Nov 10, 2023 •
edited by openjdk bot
Loading

JTabbedPane scroll button direction was incorrect because the widget type returned while painting the arrow was SPINNER_ARROW_BUTTON. Added the condition check for JTabbedPane before returning the widget type and based on the tab placement set by user, appropriate widget type is returned.

Tested the CI jobs against the fix and it was green. Link attached in JBS.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8225220: When the Tab Policy is checked,the scroll button direction displayed incorrectly. (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16601/head:pull/16601
$ git checkout pull/16601

Update a local copy of the PR:
$ git checkout pull/16601
$ git pull https://git.openjdk.org/jdk.git pull/16601/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16601

View PR using the GUI difftool:
$ git pr show -t 16601

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16601.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 10, 2023

👋 Welcome back abhiscxk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 10, 2023

@kumarabhi006 The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Nov 10, 2023
TejeshR13
TejeshR13 reviewed Nov 14, 2023
View reviewed changes
test/jdk/javax/swing/JTabbedPane/TestJTabbedPaneArrowDirection.java Outdated
} finally {
SwingUtilities.invokeAndWait(() -> {
if (frame != null) {
frame.dispose();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dispose is not required here, since you are adding it to passFailJFrame.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 21, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 21, 2023

Webrevs

TejeshR13
TejeshR13 approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@TejeshR13 TejeshR13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@openjdk
Copy link

openjdk bot commented Nov 27, 2023

@kumarabhi006 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8225220: When the Tab Policy is checked,the scroll button direction displayed incorrectly.

Reviewed-by: tr, psadhukhan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 548 new commits pushed to the master branch:

  • bddcd08: 8304701: Request with timeout aborts later in-flight request on HTTP/1.1 cxn
  • 91279fc: 8319778: Remove unreachable code in ObjectSynchronizer::exit
  • 6aa1976: 8320363: ppc64 TypeEntries::type_unknown logic looks wrong, missed optimization opportunity
  • 4d50df6: 8320691: Timeout handler on Windows takes 2 hours to complete
  • 0c9a61c: 8319220: Pattern matching switch with a lot of cases is unduly slow
  • 26c3390: 8320383: refresh libraries cache on AIX in VMError::report
  • fc31474: 8318913: The module-infos for --release data do not contain pre-set versions
  • df1b896: 8320679: [JVMCI] invalid code in PushLocalFrame event message
  • c75c388: 8318776: Require supports_cx8 to always be true
  • 14557e7: 8314502: Change the comparator taking version of GrowableArray::find to be a template method
  • ... and 538 more: https://git.openjdk.org/jdk/compare/4ea1b99c1a6efe144af381ea538f93718e9baf74...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 27, 2023
@kumarabhi006
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 4, 2023

Going to push as commit ed5b8c3.
Since your change was applied there have been 671 commits pushed to the master branch:

  • f32ab8c: 8320924: Improve heap dump performance by optimizing archived object checks
  • 93b9235: 8321120: Shenandoah: Remove ShenandoahElasticTLAB flag
  • 9b8eaa2: 8319872: AArch64: [vectorapi] Implementation of unsigned (zero extended) casts
  • b9b8263: 8317307: test/jdk/com/sun/jndi/ldap/LdapPoolTimeoutTest.java fails with ConnectException: Connection timed out: no further information
  • 0d0a657: 5108458: JTable does not properly layout its content
  • 2b00ac0: 8308753: Class-File API transition to Preview
  • b9df827: 8309871: jdk/jfr/api/consumer/recordingstream/TestSetEndTime.java timed out
  • 9498469: 8318983: Fix comment typo in PKCS12Passwd.java
  • 4dcbd13: 8314905: jdk/jfr/tool/TestView.java fails with RuntimeException 'Invoked Concurrent' missing from stdout/stderr
  • 5dee2a3: 8320440: Implementation of Structured Concurrency (Second Preview)
  • ... and 661 more: https://git.openjdk.org/jdk/compare/4ea1b99c1a6efe144af381ea538f93718e9baf74...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 4, 2023
@openjdk openjdk bot closed this Dec 4, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 4, 2023
@openjdk
Copy link

openjdk bot commented Dec 4, 2023

@kumarabhi006 Pushed as commit ed5b8c3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prsadhuk prsadhuk prsadhuk approved these changes

@TejeshR13 TejeshR13 TejeshR13 approved these changes

Assignees
No one assigned
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kumarabhi006 @prsadhuk @TejeshR13