Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JDK-8319927: Log that IEEE rounding mode was corrupted by loading a library #16618

Closed
wants to merge 1 commit into from
Closed

JDK-8319927: Log that IEEE rounding mode was corrupted by loading a library #16618

wants to merge 1 commit into from

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Nov 10, 2023 •
edited by openjdk bot
Loading

JDK-8295159 added some IEEE conformance checks and corrections on Linux and macOS/BSD , however in case of issues no logging is done, this should be improved.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8319927: Log that IEEE rounding mode was corrupted by loading a library (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16618/head:pull/16618
$ git checkout pull/16618

Update a local copy of the PR:
$ git checkout pull/16618
$ git pull https://git.openjdk.org/jdk.git pull/16618/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16618

View PR using the GUI difftool:
$ git pr show -t 16618

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16618.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 10, 2023

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 10, 2023
@openjdk
Copy link

openjdk bot commented Nov 10, 2023

@MBaesken The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Nov 10, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 10, 2023

Webrevs

GoeLin
GoeLin approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@GoeLin GoeLin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk
Copy link

openjdk bot commented Nov 15, 2023 •
edited
Loading

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8319927: Log that IEEE rounding mode was corrupted by loading a library

Reviewed-by: goetz, lucy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 62 new commits pushed to the master branch:

  • faeea07: 8319747: galoisCounterMode_AESCrypt stack walking broken
  • b4c2d1c: 8319542: Fix boundaries of region to be tested with os::is_readable_range
  • c36ec2c: 8316653: Large NMethodSizeLimit triggers assert during C1 code buffer allocation
  • 2db9ea9: 8317723: C2: CountedLoopEndNodes and Zero Trip Guards are wrongly treated as Runtime Predicate
  • eaa4417: 8319301: Static analysis warnings after JDK-8318016
  • 3452210: 8283140: Remove unused encoding classes/operands from x86_64.ad
  • f0b7eb5: 8304020: Speed up test/jdk/java/util/zip/ZipFile/TestTooManyEntries.java and clarify its purpose
  • ffa35d8: 8301997: Move method resolution information out of the cpCache
  • 891d8cf: 8319986: Invalid/inconsistent description and example for DateFormat
  • 536b1ce: 8320130: Problemlist 2 vmTestbase/nsk/jdi/StepRequest/addClassFilter_rt tests with Xcomp
  • ... and 52 more: https://git.openjdk.org/jdk/compare/ea1ffa34192448317ce9a61a3588b0dee3a2ef44...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 15, 2023
@MBaesken MBaesken changed the title JDK-8319927: Add some logging after 8295159 JDK-8319927: Log that IEEE rounding mode was corrupted by loading a library Nov 15, 2023
RealLucy
RealLucy approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@RealLucy RealLucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
The supplemental logging may prove helpful. Thanks for adding.

@MBaesken
Copy link
Member Author

Hi Goetz and Lutz, thanks for the reviews !

/integrate

@openjdk
Copy link

openjdk bot commented Nov 16, 2023

Going to push as commit 9faead1.
Since your change was applied there have been 66 commits pushed to the master branch:

  • f33c874: 8319764: C2 compilation asserts during incremental inlining because Phi input is out of bounds
  • 6868b37: 8318826: C2: "Bad graph detected in build_loop_late" with incremental inlining
  • 1d96886: 8319531: FileServerHandler::discardRequestBody could be improved
  • 73e19f6: 8319825: jdk.net/jdk.net.ExtendedSocketOptions::IP_DONTFRAGMENT is missing @SInCE 19
  • faeea07: 8319747: galoisCounterMode_AESCrypt stack walking broken
  • b4c2d1c: 8319542: Fix boundaries of region to be tested with os::is_readable_range
  • c36ec2c: 8316653: Large NMethodSizeLimit triggers assert during C1 code buffer allocation
  • 2db9ea9: 8317723: C2: CountedLoopEndNodes and Zero Trip Guards are wrongly treated as Runtime Predicate
  • eaa4417: 8319301: Static analysis warnings after JDK-8318016
  • 3452210: 8283140: Remove unused encoding classes/operands from x86_64.ad
  • ... and 56 more: https://git.openjdk.org/jdk/compare/ea1ffa34192448317ce9a61a3588b0dee3a2ef44...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 16, 2023
@openjdk openjdk bot closed this Nov 16, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 16, 2023
@openjdk
Copy link

openjdk bot commented Nov 16, 2023

@MBaesken Pushed as commit 9faead1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

theRealAph
theRealAph reviewed Nov 17, 2023
View reviewed changes
src/hotspot/os/bsd/os_bsd.cpp
@@ -1004,7 +1010,17 @@ void *os::Bsd::dlopen_helper(const char *filename, int mode) {
// flags. Silently fix things now.
int rtn = fesetenv(&default_fenv);
assert(rtn == 0, "fesetenv must succeed");
assert(IEEE_subnormal_handling_OK(), "fsetenv didn't work");
bool ieee_handling_after_issue = IEEE_subnormal_handling_OK();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a misleading name. It should be something explicit like ieee_handling_succeeded. Still, I suppose it's too late now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay why not ieee_handling_succeeded; I can change the variable name in the follow up JDK-8321017 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theRealAph theRealAph theRealAph left review comments

@GoeLin GoeLin GoeLin approved these changes

@RealLucy RealLucy RealLucy approved these changes

Assignees
No one assigned
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MBaesken @theRealAph @GoeLin @RealLucy