JDK-8319927: Log that IEEE rounding mode was corrupted by loading a library

[MBaesken]

JDK-8295159 added some IEEE conformance checks and corrections on Linux and macOS/BSD , however in case of issues no logging is done, this should be improved.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8319927: Log that IEEE rounding mode was corrupted by loading a library (Enhancement - P4)

Reviewers

• Goetz Lindenmaier (@GoeLin - Reviewer)
• Lutz Schmidt (@RealLucy - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16618/head:pull/16618
$ git checkout pull/16618

Update a local copy of the PR:
$ git checkout pull/16618
$ git pull https://git.openjdk.org/jdk.git pull/16618/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16618

View PR using the GUI difftool:
$ git pr show -t 16618

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16618.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@MBaesken The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (026d2739)

[GoeLin]

LGTM

[openjdk]

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8319927: Log that IEEE rounding mode was corrupted by loading a library

Reviewed-by: goetz, lucy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 62 new commits pushed to the master branch:

• faeea07: 8319747: galoisCounterMode_AESCrypt stack walking broken
• b4c2d1c: 8319542: Fix boundaries of region to be tested with os::is_readable_range
• c36ec2c: 8316653: Large NMethodSizeLimit triggers assert during C1 code buffer allocation
• 2db9ea9: 8317723: C2: CountedLoopEndNodes and Zero Trip Guards are wrongly treated as Runtime Predicate
• eaa4417: 8319301: Static analysis warnings after JDK-8318016
• 3452210: 8283140: Remove unused encoding classes/operands from x86_64.ad
• f0b7eb5: 8304020: Speed up test/jdk/java/util/zip/ZipFile/TestTooManyEntries.java and clarify its purpose
• ffa35d8: 8301997: Move method resolution information out of the cpCache
• 891d8cf: 8319986: Invalid/inconsistent description and example for DateFormat
• 536b1ce: 8320130: Problemlist 2 vmTestbase/nsk/jdi/StepRequest/addClassFilter_rt tests with Xcomp
• ... and 52 more: https://git.openjdk.org/jdk/compare/ea1ffa34192448317ce9a61a3588b0dee3a2ef44...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[RealLucy]

LGTM.
The supplemental logging may prove helpful. Thanks for adding.

[MBaesken]

Hi Goetz and Lutz, thanks for the reviews !

/integrate

[openjdk]

Going to push as commit 9faead1.
Since your change was applied there have been 66 commits pushed to the master branch:

• f33c874: 8319764: C2 compilation asserts during incremental inlining because Phi input is out of bounds
• 6868b37: 8318826: C2: "Bad graph detected in build_loop_late" with incremental inlining
• 1d96886: 8319531: FileServerHandler::discardRequestBody could be improved
• 73e19f6: 8319825: jdk.net/jdk.net.ExtendedSocketOptions::IP_DONTFRAGMENT is missing @SInCE 19
• faeea07: 8319747: galoisCounterMode_AESCrypt stack walking broken
• b4c2d1c: 8319542: Fix boundaries of region to be tested with os::is_readable_range
• c36ec2c: 8316653: Large NMethodSizeLimit triggers assert during C1 code buffer allocation
• 2db9ea9: 8317723: C2: CountedLoopEndNodes and Zero Trip Guards are wrongly treated as Runtime Predicate
• eaa4417: 8319301: Static analysis warnings after JDK-8318016
• 3452210: 8283140: Remove unused encoding classes/operands from x86_64.ad
• ... and 56 more: https://git.openjdk.org/jdk/compare/ea1ffa34192448317ce9a61a3588b0dee3a2ef44...master

Your commit was automatically rebased without conflicts.

[openjdk]

@MBaesken Pushed as commit 9faead1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[theRealAph]

This is a misleading name. It should be something explicit like ieee_handling_succeeded. Still, I suppose it's too late now.

[MBaesken]

okay why not ieee_handling_succeeded; I can change the variable name in the follow up JDK-8321017 .