JDK-8234502 : Merge GenCollectedHeap and SerialHeap

[LizBing]

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8234502: Merge GenCollectedHeap and SerialHeap (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16623/head:pull/16623
$ git checkout pull/16623

Update a local copy of the PR:
$ git checkout pull/16623
$ git pull https://git.openjdk.org/jdk.git pull/16623/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16623

View PR using the GUI difftool:
$ git pr show -t 16623

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16623.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back LizBing! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@LizBing The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 09: Full (ecd335d8)
• 08: Full - Incremental (4a28d0e8)
• 07: Full - Incremental (12c680a3)
• 06: Full - Incremental (0563686a)
• 05: Full - Incremental (1202a7bd)
• 04: Full - Incremental (bf022a87)
• 03: Full - Incremental (8f164430)
• 02: Full - Incremental (883dd7b1)
• 01: Full - Incremental (4e74cc25)
• 00: Full (08f1f0a8)

[LizBing]

/label add hotspot-gc

[openjdk]

@LizBing
The hotspot-gc label was successfully added.

[lgxbslgx]

/reviewers 2 reviewer

[openjdk]

@lgxbslgx Only the author of the pull request or Reviewers are allowed to change the number of required reviewers.

[albertnetymk]

Maybe there is some misinterpretation about the ticket description, but I'd expect class GenCollectedHeap to be removed completely with this ticket.

Could you enable GHA (https://wiki.openjdk.org/display/SKARA/Testing) to catch potential issues for all platforms? It should show sth like "19 successful checks", e.g. in #16560.

[LizBing]

done!

[albertnetymk]

The general shape looks good. I wanna took a closer look after #16492 #16554 is merged. (I believe that can reduce the diff size of this PR slightly.)

[albertnetymk]

I just noticed I referred to the wrong PR number in my previous msg...

Could you resolve the conflict now that that PR is merged?

[LizBing]

I just noticed I referred to the wrong PR number in my previous msg...

Could you resolve the conflict now that that PR is merged?

ok!

[openjdk]

@LizBing this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout serialgc
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

[LizBing]

I will open another pr later.

[albertnetymk]

Both reusing this PR and creating another one are fine, IMO.