JDK-8319628: DateFormat does not mention IllegalArgumentException for invalid style args

[justin-curtis-lu]

Please review this PR and CSR which makes IllegalArgumentExceptions apparent for the j.text.DateFormat static factory methods that have the style parameter.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires CSR request JDK-8319868 to be approved

Issues

• JDK-8319628: DateFormat does not mention IllegalArgumentException for invalid style args (Enhancement - P4)
• JDK-8319868: DateFormat does not mention IllegalArgumentException for invalid style args (CSR)

Reviewers

• Naoto Sato (@naotoj - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16624/head:pull/16624
$ git checkout pull/16624

Update a local copy of the PR:
$ git checkout pull/16624
$ git pull https://git.openjdk.org/jdk.git pull/16624/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16624

View PR using the GUI difftool:
$ git pr show -t 16624

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16624.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@justin-curtis-lu The following labels will be automatically applied to this pull request:

• core-libs
• i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (fa795543)
• 00: Full (f1a4b6c9)

[naotoj]

I wonder if "not equal to any of the ..." may read better here.

[justin-curtis-lu]

Agreed that sounds better. Changed in both the CSR and the PR, thanks.

[naotoj]

LGTM. The CSR has also been reviewed.

[openjdk]

@justin-curtis-lu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8319628: DateFormat does not mention IllegalArgumentException for invalid style args

Reviewed-by: naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 43 new commits pushed to the master branch:

• d725b73: 8301310: The SendRawSysexMessage test may cause a JVM crash
• 12fce4b: 8287843: File::getCanonicalFile doesn't work for \?\C:\ style paths DOS device paths
• 346dbd6: 8319196: ExecutableElement.getReceiverType doesn't return receiver types for methods loaded from bytecode
• 0ea5804: 8318759: Add four DigiCert root certificates
• 6a75c24: 8319958: test/jdk/java/io/File/libGetXSpace.c does not compile on Windows 32-bit
• 58af9ae: 8316392: compiler/interpreter/TestVerifyStackAfterDeopt.java failed with SIGBUS in PcDescContainer::find_pc_desc_internal
• a75b6e5: 8191460: crash in Annotate with duplicate declaration and annotation processing enabled
• 7bb1999: 8316342: CLHSDB "dumpclass" command produces invalid classes
• 97ea5bf: 8319961: JvmtiEnvBase doesn't zero _ext_event_callbacks
• 25f9af9: 8319883: Zero: Use atomic built-ins for 64-bit accesses
• ... and 33 more: https://git.openjdk.org/jdk/compare/38745ecacddfe5e59255058b69fe31530019da16...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[justin-curtis-lu]

/integrate

[openjdk]

Going to push as commit d5abe49.
Since your change was applied there have been 43 commits pushed to the master branch:

• d725b73: 8301310: The SendRawSysexMessage test may cause a JVM crash
• 12fce4b: 8287843: File::getCanonicalFile doesn't work for \?\C:\ style paths DOS device paths
• 346dbd6: 8319196: ExecutableElement.getReceiverType doesn't return receiver types for methods loaded from bytecode
• 0ea5804: 8318759: Add four DigiCert root certificates
• 6a75c24: 8319958: test/jdk/java/io/File/libGetXSpace.c does not compile on Windows 32-bit
• 58af9ae: 8316392: compiler/interpreter/TestVerifyStackAfterDeopt.java failed with SIGBUS in PcDescContainer::find_pc_desc_internal
• a75b6e5: 8191460: crash in Annotate with duplicate declaration and annotation processing enabled
• 7bb1999: 8316342: CLHSDB "dumpclass" command produces invalid classes
• 97ea5bf: 8319961: JvmtiEnvBase doesn't zero _ext_event_callbacks
• 25f9af9: 8319883: Zero: Use atomic built-ins for 64-bit accesses
• ... and 33 more: https://git.openjdk.org/jdk/compare/38745ecacddfe5e59255058b69fe31530019da16...master

Your commit was automatically rebased without conflicts.

[openjdk]

@justin-curtis-lu Pushed as commit d5abe49.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.