Skip to content

8319970: AArch64: enable tests compiler/intrinsics/Test(Long|Integer)UnsignedDivMod.java on aarch64 #16633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Hamlin-Li
Copy link

@Hamlin-Li Hamlin-Li commented Nov 13, 2023

Hi,
Can you review the simple patch to enble tests compiler/intrinsics/Test(Long|Integer)UnsignedDivMod.java on aarch64?
Thanks!

NOTE:

  1. The intrinsics are also implemented on ppc, but as I don't have the environment to test it, so did not enable it for ppc.
  2. This fix depends on the fix in 8319960: RISC-V: compiler/intrinsics/TestInteger/LongUnsignedDivMod.java failed with "counts: Graph contains wrong number of nodes" #16630, else the tests will fail.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8319970: AArch64: enable tests compiler/intrinsics/Test(Long|Integer)UnsignedDivMod.java on aarch64 (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16633/head:pull/16633
$ git checkout pull/16633

Update a local copy of the PR:
$ git checkout pull/16633
$ git pull https://git.openjdk.org/jdk.git pull/16633/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16633

View PR using the GUI difftool:
$ git pr show -t 16633

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16633.diff

Webrev

Link to Webrev Comment

@Hamlin-Li Hamlin-Li changed the title 8319970 AArch64: enable tests compiler/intrinsics/Test(Long|Integer)UnsignedDivMod.java on aarch64 8319970: AArch64: enable tests compiler/intrinsics/Test(Long|Integer)UnsignedDivMod.java on aarch64 Nov 13, 2023
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 13, 2023

👋 Welcome back mli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 13, 2023
@openjdk
Copy link

openjdk bot commented Nov 13, 2023

@Hamlin-Li The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Nov 13, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 13, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 13, 2023

@Hamlin-Li This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8319970: AArch64: enable tests compiler/intrinsics/Test(Long|Integer)UnsignedDivMod.java on aarch64

Reviewed-by: aph, haosun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 50 new commits pushed to the master branch:

  • fe0ccdf: 8319640: ClassicFormat::parseObject (from DateTimeFormatter) does not conform to the javadoc and may leak DateTimeException
  • 1802cb5: 8319570: Change to GCC 13.2.0 for building on Linux at Oracle
  • d992033: 8317562: [JFR] Compilation queue statistics
  • 965ae72: 8319753: Duration javadoc has "period" instead of "duration" in several places
  • 115b074: 8319944: Remove DynamicDumpSharedSpaces
  • c0507af: 8319818: Address GCC 13.2.0 warnings (stringop-overflow and dangling-pointer)
  • 3684b4b: 8306116: Update CLDR to Version 44.0
  • 88ccd64: 8296250: Update ICU4J to Version 74.1
  • 03db828: 8319650: Improve heap dump performance with class metadata caching
  • b41b00a: 8319820: Use unnamed variables in the FFM implementation
  • ... and 40 more: https://git.openjdk.org/jdk/compare/1e687b4529ae695d991623dc13796faecd6be7da...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 13, 2023
@Hamlin-Li
Copy link
Author

@theRealAph @shqking Thanks for your reviewing.
I will push after #16630

@Hamlin-Li
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 14, 2023

Going to push as commit c80e691.
Since your change was applied there have been 58 commits pushed to the master branch:

  • 856c280: 8319960: RISC-V: compiler/intrinsics/TestInteger/LongUnsignedDivMod.java failed with "counts: Graph contains wrong number of nodes"
  • cb7875d: 8318218: RISC-V: C2 CompressBits
  • 1535528: 8318479: [jmh] the test security.CacheBench failed for multiple threads run
  • 95bd92a: 8210807: Printing a JTable with a JScrollPane prints table without rows populated
  • 21cda19: 8309203: C2: remove copy-by-value of GrowableArray for InterfaceSet
  • b120a05: 8319406: x86: Shorter movptr(reg, imm) for 32-bit immediates
  • 7df73a2: 8318817: Could not reserve enough space in CodeHeap 'profiled nmethods' (0K)
  • 07eaea8: 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test
  • fe0ccdf: 8319640: ClassicFormat::parseObject (from DateTimeFormatter) does not conform to the javadoc and may leak DateTimeException
  • 1802cb5: 8319570: Change to GCC 13.2.0 for building on Linux at Oracle
  • ... and 48 more: https://git.openjdk.org/jdk/compare/1e687b4529ae695d991623dc13796faecd6be7da...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 14, 2023
@openjdk openjdk bot closed this Nov 14, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 14, 2023
@openjdk
Copy link

openjdk bot commented Nov 14, 2023

@Hamlin-Li Pushed as commit c80e691.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@Hamlin-Li Hamlin-Li deleted the enable-TestLong-IntegerUnsignedDivMod-on-aarch64 branch February 27, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants