8319103: Popups that request focus are not shown on Linux with Wayland

[azvegint]

This is the fix for the regression introduced in JDK-8280993.

That fix was to dismiss a popup if the owner loses the window focus when running in Wayland, and didn't take into account that the popup itself can be focusable.

This fix closes the popup only if the focus moves away from the calling window and the popup itself.

There is no jtreg test provided because it requires transferring the window focus to a non-X11 window, and our current robot implementation does not allow this.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8319103: Popups that request focus are not shown on Linux with Wayland (Bug - P3)

Reviewers

• Sergey Bylokhov (@mrserb - Reviewer) ⚠️ Review applies to 06850c0d
• Phil Race (@prrace - Reviewer) ⚠️ Review applies to 6590a995

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16636/head:pull/16636
$ git checkout pull/16636

Update a local copy of the PR:
$ git checkout pull/16636
$ git pull https://git.openjdk.org/jdk.git pull/16636/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16636

View PR using the GUI difftool:
$ git pr show -t 16636

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16636.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back azvegint! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@azvegint The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 03: Full - Incremental (c50fb179)
• 02: Full - Incremental (6590a995)
• 01: Full - Incremental (06850c0d)
• 00: Full (0421fedc)

[mrserb]

There is no jtreg test provided because it requires transferring the window focus to a non-X11 window, and our current robot implementation does not allow this.

Can this be covered by the manual test? We have a few manual tests which asked to use both java and native apps together.

[azvegint]

Can this be covered by the manual test? We have a few manual tests which asked to use both java and native apps together.

Sure, test added.

[openjdk]

@azvegint This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8319103: Popups that request focus are not shown on Linux with Wayland

Reviewed-by: serb, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 46 new commits pushed to the master branch:

• ffa35d8: 8301997: Move method resolution information out of the cpCache
• 891d8cf: 8319986: Invalid/inconsistent description and example for DateFormat
• 536b1ce: 8320130: Problemlist 2 vmTestbase/nsk/jdi/StepRequest/addClassFilter_rt tests with Xcomp
• 0bda467: 8319187: Add three eMudhra emSign roots
• 3c6ffca: 8318219: RISC-V: C2 ExpandBits
• 77a6966: 8320053: GHA: Cross-compile gtest code
• 4f4d00f: 8319966: AIX: expected [[0:i4]] but found [[0:I4]] after JDK-8319882
• 2e34a2e: 8318671: Potential uninitialized uintx value after JDK-8317683
• fac6b51: 8319781: RISC-V: Refactor UseRVV related checks
• bad6999: 8313672: C2: PhaseCCP does not correctly track analysis dependencies involving shift, convert, and mask
• ... and 36 more: https://git.openjdk.org/jdk/compare/03db82818b905f21cb5ad1d56a687e238b4a6e33...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[azvegint]

/integrate

[openjdk]

Going to push as commit f3ed275.
Since your change was applied there have been 60 commits pushed to the master branch:

• 9e7a3ae: 8319630: Monitor final audit log lacks separator
• 87be6b6: 8318757: VM_ThreadDump asserts in interleaved ObjectMonitor::deflate_monitor calls
• 9faead1: 8319927: Log that IEEE rounding mode was corrupted by loading a library
• f33c874: 8319764: C2 compilation asserts during incremental inlining because Phi input is out of bounds
• 6868b37: 8318826: C2: "Bad graph detected in build_loop_late" with incremental inlining
• 1d96886: 8319531: FileServerHandler::discardRequestBody could be improved
• 73e19f6: 8319825: jdk.net/jdk.net.ExtendedSocketOptions::IP_DONTFRAGMENT is missing @SInCE 19
• faeea07: 8319747: galoisCounterMode_AESCrypt stack walking broken
• b4c2d1c: 8319542: Fix boundaries of region to be tested with os::is_readable_range
• c36ec2c: 8316653: Large NMethodSizeLimit triggers assert during C1 code buffer allocation
• ... and 50 more: https://git.openjdk.org/jdk/compare/03db82818b905f21cb5ad1d56a687e238b4a6e33...master

Your commit was automatically rebased without conflicts.

[openjdk]

@azvegint Pushed as commit f3ed275.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.