8319961: JvmtiEnvBase doesn't zero _ext_event_callbacks

[wkia]

Zero'ing memory of extension event callbacks

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8319961: JvmtiEnvBase doesn't zero _ext_event_callbacks (Bug - P4)

Reviewers

• David Holmes (@dholmes-ora - Reviewer) ⚠️ Review applies to aa3bfaec

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16647/head:pull/16647
$ git checkout pull/16647

Update a local copy of the PR:
$ git checkout pull/16647
$ git pull https://git.openjdk.org/jdk.git pull/16647/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16647

View PR using the GUI difftool:
$ git pr show -t 16647

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16647.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back rmarchenko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@wkia The following labels will be automatically applied to this pull request:

• hotspot
• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (2ef1e341)
• 00: Full (aa3bfaec)

[openjdk]

@wkia This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8319961: JvmtiEnvBase doesn't zero _ext_event_callbacks

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

• c80e691: 8319970: AArch64: enable tests compiler/intrinsics/Test(Long|Integer)UnsignedDivMod.java on aarch64
• 856c280: 8319960: RISC-V: compiler/intrinsics/TestInteger/LongUnsignedDivMod.java failed with "counts: Graph contains wrong number of nodes"
• cb7875d: 8318218: RISC-V: C2 CompressBits
• 1535528: 8318479: [jmh] the test security.CacheBench failed for multiple threads run
• 95bd92a: 8210807: Printing a JTable with a JScrollPane prints table without rows populated
• 21cda19: 8309203: C2: remove copy-by-value of GrowableArray for InterfaceSet
• b120a05: 8319406: x86: Shorter movptr(reg, imm) for 32-bit immediates
• 7df73a2: 8318817: Could not reserve enough space in CodeHeap 'profiled nmethods' (0K)
• 07eaea8: 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test
• fe0ccdf: 8319640: ClassicFormat::parseObject (from DateTimeFormatter) does not conform to the javadoc and may leak DateTimeException
• ... and 7 more: https://git.openjdk.org/jdk/compare/03db82818b905f21cb5ad1d56a687e238b4a6e33...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dholmes-ora) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[wkia]

The previous test run was OK https://github.com/wkia/jdk/actions/runs/6852317395

Now it fails on MacOS: "hotspot/jtreg/gc/TestAllocHumongousFragment.java: java.lang.OutOfMemoryError: Java heap space", so I guess it is caused by infrastructure issues.

/integrate

[openjdk]

@wkia
Your change (at version 2ef1e34) is now ready to be sponsored by a Committer.

[yan-too]

/sponsor

[openjdk]

Going to push as commit 97ea5bf.
Since your change was applied there have been 19 commits pushed to the master branch:

• 25f9af9: 8319883: Zero: Use atomic built-ins for 64-bit accesses
• 9c98270: 8254693: Add Panama feature to pass heap segments to native code
• c80e691: 8319970: AArch64: enable tests compiler/intrinsics/Test(Long|Integer)UnsignedDivMod.java on aarch64
• 856c280: 8319960: RISC-V: compiler/intrinsics/TestInteger/LongUnsignedDivMod.java failed with "counts: Graph contains wrong number of nodes"
• cb7875d: 8318218: RISC-V: C2 CompressBits
• 1535528: 8318479: [jmh] the test security.CacheBench failed for multiple threads run
• 95bd92a: 8210807: Printing a JTable with a JScrollPane prints table without rows populated
• 21cda19: 8309203: C2: remove copy-by-value of GrowableArray for InterfaceSet
• b120a05: 8319406: x86: Shorter movptr(reg, imm) for 32-bit immediates
• 7df73a2: 8318817: Could not reserve enough space in CodeHeap 'profiled nmethods' (0K)
• ... and 9 more: https://git.openjdk.org/jdk/compare/03db82818b905f21cb5ad1d56a687e238b4a6e33...master

Your commit was automatically rebased without conflicts.

[openjdk]

@yan-too @wkia Pushed as commit 97ea5bf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[dcubed-ojdk]

Doing a post integration review.

This is a trivial fix and does not need a second review nor wait 24 hours.

[dcubed-ojdk]

Just a heads up that HotSpot code normally requires two reviews (1 from a (R)eviewer)
and 24 hours unless it is called trivial AND agreed to be trivial by your reviewers.

[wkia]

@dcubed-ojdk Sorry, I didn't know that. Could you point the discussion about +24 hours waiting please?

BTW I seems like both requirements may be automated in github.

[dcubed-ojdk]

Sure. Here's the relevant sub-section from the "OpenJDK Developers’ Guide":

https://openjdk.org/guide/index.html#life-of-a-pr

Get the required reviews

At least one Reviewer knowledgeable in each area being changed must approve every change. Some areas (e.g. Client and HotSpot) require two reviewers in most cases, so be sure to read the relevant OpenJDK group pages for advice or ask your sponsor.

Be open to comments and polite in replies. Remember that the reviewer wants to improve the world just as much as you do, only in a slightly different way. If you don’t understand some comment, ask the reviewer to clarify. Accept authority when applicable. If you’re making changes in an area where you’re not the area expert, acknowledge that your reviewers may be. Take their advice seriously, even if it is to not make the change. There are many reasons why a change may get rejected. And you did read the section [Things to consider before changing OpenJDK code], right?

[dholmes-ora]

Also see:

https://openjdk.org/guide/index.html#hotspot-development

and the definition of "trivial" in the Glossary.