Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8245107: Use Unified Logging in trace_method_handle_stub() #1665

Closed
wants to merge 1 commit into from

Conversation

@chhagedorn
Copy link
Member

@chhagedorn chhagedorn commented Dec 7, 2020

This changes the logging of method handles from specifying Verbose to using unified logging with level Trace.

I only tested it on x86. Could anybody verify that it also works on ARM, S390 and PPC?

Thanks,
Christian


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8245107: Use Unified Logging in trace_method_handle_stub()

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1665/head:pull/1665
$ git checkout pull/1665

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 7, 2020

👋 Welcome back chagedorn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Dec 7, 2020

@chhagedorn The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot label Dec 7, 2020
@chhagedorn chhagedorn marked this pull request as ready for review Dec 7, 2020
@openjdk openjdk bot added the rfr label Dec 7, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 7, 2020

Webrevs

coleenp
coleenp approved these changes Dec 7, 2020
Copy link

@coleenp coleenp left a comment

Thank you for doing this. I probably should have with my fix but it's better that someone who might read this information to do it.

@openjdk
Copy link

@openjdk openjdk bot commented Dec 7, 2020

@chhagedorn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8245107: Use Unified Logging in trace_method_handle_stub()

Reviewed-by: coleenp, mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 66 new commits pushed to the master branch:

  • 2c04fc0: 8257037: No javac warning when calling deprecated constructor with diamond
  • 46b35ac: 8257798: [PPC64] undefined reference to Klass::vtable_start_offset()
  • ecd7e47: 8257793: Shenandoah: SATB barrier should only filter out already strongly marked oops
  • e08b9ed: 8257820: Remove gc/ergonomics/TestMinHeapSize.java as it is too brittle
  • 637b0c6: 8246778: Compiler implementation for Sealed Classes (Second Preview)
  • 09707dd: 8252807: The jdk.jfr.Recording.getStream does not work when toDisk is disabled
  • 04ce8e3: 8257184: Upstream 8252504: Add a method to MemoryLayout which returns a offset-computing method handle
  • 5a03e47: 8255560: Class::isRecord should check that the current class is final and not abstract
  • 8e8e584: 8257588: Make os::_page_sizes a bitmask
  • 566d77a: 8254802: ThrowingPushPromisesAsStringCustom.java fails in "try throwing in GET_BODY"
  • ... and 56 more: https://git.openjdk.java.net/jdk/compare/4a267f1bc2b025aae2cb9df7283156aeb0282406...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Dec 7, 2020
@chhagedorn
Copy link
Member Author

@chhagedorn chhagedorn commented Dec 7, 2020

Thanks Coleen for your review!

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Looks correct. Works on PPC64 and s390.

@chhagedorn
Copy link
Member Author

@chhagedorn chhagedorn commented Dec 7, 2020

Thanks Martin for your review and the verification on PPC64 and s390!

@chhagedorn
Copy link
Member Author

@chhagedorn chhagedorn commented Dec 9, 2020

Could anybody also quickly verify that the changes in methodHandles_arm.cpp build and are correct?

@chhagedorn
Copy link
Member Author

@chhagedorn chhagedorn commented Dec 9, 2020

Nevermind, I could verify that it builds correctly.

@chhagedorn
Copy link
Member Author

@chhagedorn chhagedorn commented Dec 9, 2020

/integrate

@openjdk openjdk bot closed this Dec 9, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 9, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 9, 2020

@chhagedorn Since your change was applied there have been 115 commits pushed to the master branch:

  • 0201a33: 8255959: Timeouts in VectorConversion tests
  • d3dddb6: 8256657: Add cross-compiled build for Windows+Arm64 to submit workflow
  • 616b1f1: 8257516: define test group for manual tests
  • 5bdce9b: 8257639: Update usage of "type" terminology in java.lang.Enum & java.lang.Record
  • b4615c6: 8256580: Fault in new grid display
  • df55ecd: 8257794: Zero: assert(istate->_stack_limit == istate->_thread->last_Java_sp() + 1) failed: wrong on Linux/x86_32
  • fae7961: 8257884: Re-enable sun/security/ssl/SSLSocketImpl/SSLSocketLeak.java as automatic test
  • 79f1dfb: 8255987: JDI tests fail with com.sun.jdi.ObjectCollectedException
  • 9ce3d80: 8257887: java/foreign/TestSegments.java test fails on 32-bit after JDK-8257186
  • 10da767: 8257847: Tiered should publish MDO data pointer for interpreter after profile start
  • ... and 105 more: https://git.openjdk.java.net/jdk/compare/4a267f1bc2b025aae2cb9df7283156aeb0282406...master

Your commit was automatically rebased without conflicts.

Pushed as commit f148915.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@chhagedorn chhagedorn deleted the JDK-8245107 branch Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants