-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8319567: Update java/lang/invoke tests to support vm flags #16666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back mchung! A progress list of the required criteria for merging this PR into |
/issue add 8319568,8319672,8319676,8319677 |
@mlchung Adding additional issue to issue list: Adding additional issue to issue list: Adding additional issue to issue list: |
Webrevs
|
@mlchung This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 38 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 1588dd9.
Your commit was automatically rebased without conflicts. |
This PR includes test fixes for the following issues:
8319567: Update java/lang/invoke tests to support vm flags
8319568: Update java/lang/reflect/exeCallerAccessTest/CallerAccessTest.java to accept vm flags
8319672: Several classloader tests ignore VM flags
8319676: A couple of jdk/modules/incubator/ tests ignore VM flags
8319677: Test jdk/internal/misc/VM/RuntimeArguments.java should be marked as flagless
It converts the test to use
ProcessTools::createTestJavaProcessBuilder
orcreateNativeTestJavaProcessBuilder
so that the test will support VM flags passed to jtreg. A couple tests that ignore VM flags should useProcessTools::createLimtiedTestJavaProcessBuilder
and marks the test with@requires vm.flagless
.Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16666/head:pull/16666
$ git checkout pull/16666
Update a local copy of the PR:
$ git checkout pull/16666
$ git pull https://git.openjdk.org/jdk.git pull/16666/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 16666
View PR using the GUI difftool:
$ git pr show -t 16666
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16666.diff
Webrev
Link to Webrev Comment