Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8319567: Update java/lang/invoke tests to support vm flags #16666

Closed
wants to merge 3 commits into from

Conversation

mlchung
Copy link
Member

@mlchung mlchung commented Nov 14, 2023

This PR includes test fixes for the following issues:

8319567: Update java/lang/invoke tests to support vm flags
8319568: Update java/lang/reflect/exeCallerAccessTest/CallerAccessTest.java to accept vm flags
8319672: Several classloader tests ignore VM flags
8319676: A couple of jdk/modules/incubator/ tests ignore VM flags
8319677: Test jdk/internal/misc/VM/RuntimeArguments.java should be marked as flagless

It converts the test to use ProcessTools::createTestJavaProcessBuilder or createNativeTestJavaProcessBuilder so that the test will support VM flags passed to jtreg. A couple tests that ignore VM flags should use ProcessTools::createLimtiedTestJavaProcessBuilder and marks the test with @requires vm.flagless.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8319567: Update java/lang/invoke tests to support vm flags (Sub-task - P4)
  • JDK-8319568: Update java/lang/reflect/exeCallerAccessTest/CallerAccessTest.java to accept vm flags (Sub-task - P4)
  • JDK-8319672: Several classloader tests ignore VM flags (Sub-task - P4)
  • JDK-8319676: A couple of jdk/modules/incubator/ tests ignore VM flags (Sub-task - P4)
  • JDK-8319677: Test jdk/internal/misc/VM/RuntimeArguments.java should be marked as flagless (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16666/head:pull/16666
$ git checkout pull/16666

Update a local copy of the PR:
$ git checkout pull/16666
$ git pull https://git.openjdk.org/jdk.git pull/16666/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16666

View PR using the GUI difftool:
$ git pr show -t 16666

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16666.diff

Webrev

Link to Webrev Comment

8319568: Update java/lang/reflect/exeCallerAccessTest/CallerAccessTest.java to accept vm flags
8319672: Several classloader tests ignore VM flags
8319676: A couple of jdk/modules/incubator/ tests ignore VM flags
8319677: Test jdk/internal/misc/VM/RuntimeArguments.java should be marked as flagless
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 14, 2023

👋 Welcome back mchung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@mlchung
Copy link
Member Author

mlchung commented Nov 14, 2023

/issue add 8319568,8319672,8319676,8319677

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 14, 2023
@openjdk
Copy link

openjdk bot commented Nov 14, 2023

@mlchung
Adding additional issue to issue list: 8319568: Update java/lang/reflect/exeCallerAccessTest/CallerAccessTest.java to accept vm flags.

Adding additional issue to issue list: 8319672: Several classloader tests ignore VM flags.

Adding additional issue to issue list: 8319676: A couple of jdk/modules/incubator/ tests ignore VM flags.

Adding additional issue to issue list: 8319677: Test jdk/internal/misc/VM/RuntimeArguments.java should be marked as flagless.

@openjdk
Copy link

openjdk bot commented Nov 14, 2023

@mlchung The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Nov 14, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 14, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 15, 2023

@mlchung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8319567: Update java/lang/invoke tests to support vm flags
8319568: Update java/lang/reflect/exeCallerAccessTest/CallerAccessTest.java to accept vm flags
8319672: Several classloader tests ignore VM flags
8319676: A couple of jdk/modules/incubator/ tests ignore VM flags
8319677: Test jdk/internal/misc/VM/RuntimeArguments.java should be marked as flagless

Reviewed-by: jvernee, lmesnik

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 38 new commits pushed to the master branch:

  • 9727f4b: 8320199: Fix HTML 5 errors in java.math.BigInteger
  • d6aa7c8: 8314621: ClassNotFoundException due to lambda reference to elided anonymous inner class
  • 52e2878: 8319987: compilation of sealed classes leads to infinite recursion
  • b05e69f: 8320209: VectorMaskGen clobbers rflags on x86_64
  • f3ed275: 8319103: Popups that request focus are not shown on Linux with Wayland
  • 9e7a3ae: 8319630: Monitor final audit log lacks separator
  • 87be6b6: 8318757: VM_ThreadDump asserts in interleaved ObjectMonitor::deflate_monitor calls
  • 9faead1: 8319927: Log that IEEE rounding mode was corrupted by loading a library
  • f33c874: 8319764: C2 compilation asserts during incremental inlining because Phi input is out of bounds
  • 6868b37: 8318826: C2: "Bad graph detected in build_loop_late" with incremental inlining
  • ... and 28 more: https://git.openjdk.org/jdk/compare/12fce4b715f2c8b0091f5c229fcc3e3707290489...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 15, 2023
@mlchung
Copy link
Member Author

mlchung commented Nov 16, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Nov 16, 2023

Going to push as commit 1588dd9.
Since your change was applied there have been 38 commits pushed to the master branch:

  • 9727f4b: 8320199: Fix HTML 5 errors in java.math.BigInteger
  • d6aa7c8: 8314621: ClassNotFoundException due to lambda reference to elided anonymous inner class
  • 52e2878: 8319987: compilation of sealed classes leads to infinite recursion
  • b05e69f: 8320209: VectorMaskGen clobbers rflags on x86_64
  • f3ed275: 8319103: Popups that request focus are not shown on Linux with Wayland
  • 9e7a3ae: 8319630: Monitor final audit log lacks separator
  • 87be6b6: 8318757: VM_ThreadDump asserts in interleaved ObjectMonitor::deflate_monitor calls
  • 9faead1: 8319927: Log that IEEE rounding mode was corrupted by loading a library
  • f33c874: 8319764: C2 compilation asserts during incremental inlining because Phi input is out of bounds
  • 6868b37: 8318826: C2: "Bad graph detected in build_loop_late" with incremental inlining
  • ... and 28 more: https://git.openjdk.org/jdk/compare/12fce4b715f2c8b0091f5c229fcc3e3707290489...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 16, 2023
@openjdk openjdk bot closed this Nov 16, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 16, 2023
@openjdk
Copy link

openjdk bot commented Nov 16, 2023

@mlchung Pushed as commit 1588dd9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlchung mlchung deleted the test-vm-flags branch February 22, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants