Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8318480: Obsolete UseCounterDecay and remove CounterDecayMinIntervalLength #16673

Closed
wants to merge 4 commits into from

Conversation

dlunde
Copy link
Member

@dlunde dlunde commented Nov 15, 2023

This changeset obsoletes the leftover (i.e., no longer used for anything) product compiler flag UseCounterDecay (requires CSR) and removes the leftover develop flag CounterDecayMinIntervalLength.

Changes:

  • Obsolete UseCounterDecay in JDK 22 and expire it in JDK 23.
  • Completely remove CounterDecayMinIntervalLength.

Testing

Platforms: windows-x64, linux-x64, linux-aarch64, macosx-x64, macosx-aarch64.

  • tier1
  • HotSpot parts of tier2 and tier3

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Change requires CSR request JDK-8320162 to be approved
  • Commit message must refer to an issue

Issues

  • JDK-8318480: Obsolete UseCounterDecay and remove CounterDecayMinIntervalLength (Enhancement - P4)
  • JDK-8320162: Obsolete UseCounterDecay (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16673/head:pull/16673
$ git checkout pull/16673

Update a local copy of the PR:
$ git checkout pull/16673
$ git pull https://git.openjdk.org/jdk.git pull/16673/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16673

View PR using the GUI difftool:
$ git pr show -t 16673

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16673.diff

Webrev

Link to Webrev Comment

@dlunde
Copy link
Member Author

dlunde commented Nov 15, 2023

/csr needed

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 15, 2023

👋 Welcome back dlunde! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8318480 8318480: UseCounterDecay and CounterDecayMinIntervalLength are unused and should be removed Nov 15, 2023
@openjdk openjdk bot added rfr Pull request is ready for review csr Pull request needs approved CSR before integration labels Nov 15, 2023
@openjdk
Copy link

openjdk bot commented Nov 15, 2023

@dlunde has indicated that a compatibility and specification (CSR) request is needed for this pull request.

@dlunde please create a CSR request for issue JDK-8318480 with the correct fix version. This pull request cannot be integrated until the CSR request is approved.

@openjdk
Copy link

openjdk bot commented Nov 15, 2023

@dlunde The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Nov 15, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 15, 2023

Webrevs

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the description of UseCounterDecay in globals.hpp should be changed to "Adjust recompilation counters (deprecated)"

@dlunde dlunde changed the title 8318480: UseCounterDecay and CounterDecayMinIntervalLength are unused and should be removed 8318480: Deprecate UseCounterDecay and remove CounterDecayMinIntervalLength Nov 15, 2023
@dlunde
Copy link
Member Author

dlunde commented Nov 15, 2023

I think the description of UseCounterDecay in globals.hpp should be changed to "Adjust recompilation counters (deprecated)"

Thanks, updated.

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Member

@lmesnik lmesnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update copyrgiths.

@dlunde
Copy link
Member Author

dlunde commented Nov 15, 2023

Please update copyrgiths.

Right, thanks @lmesnik. Updated.

@openjdk
Copy link

openjdk bot commented Nov 15, 2023

@dlunde This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8318480: Obsolete UseCounterDecay and remove CounterDecayMinIntervalLength

Reviewed-by: thartmann, lmesnik, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 98 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TobiHartmann, @lmesnik, @dholmes-ora) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed csr Pull request needs approved CSR before integration labels Nov 15, 2023
Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As UseCounterDecay already does nothing there is no need to have a deprecation step - just go straight to obsoletion. The only difference to the user will be the message they see.

@dlunde
Copy link
Member Author

dlunde commented Nov 16, 2023

Thanks @dholmes-ora, I agree (but was under the impression you always had to deprecate flags as a first step). I'll revise the CSR and changeset to directly obsolete the flag instead.

Edit: now saw the CSR was already approved. I'll investigate if we can reopen and revise it.

@dlunde dlunde changed the title 8318480: Deprecate UseCounterDecay and remove CounterDecayMinIntervalLength 8318480: Obsolete UseCounterDecay and remove CounterDecayMinIntervalLength Nov 17, 2023
@openjdk openjdk bot added csr Pull request needs approved CSR before integration and removed ready Pull request is ready to be integrated labels Nov 17, 2023
Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still good.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 20, 2023
@openjdk openjdk bot removed the csr Pull request needs approved CSR before integration label Nov 20, 2023
@dlunde
Copy link
Member Author

dlunde commented Nov 21, 2023

Thanks @dholmes-ora and @TobiHartmann. Integrating now (but I require a sponsor).

@dlunde
Copy link
Member Author

dlunde commented Nov 21, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 21, 2023
@openjdk
Copy link

openjdk bot commented Nov 21, 2023

@dlunde
Your change (at version 611ac09) is now ready to be sponsored by a Committer.

@dholmes-ora
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 21, 2023

Going to push as commit 9232070.
Since your change was applied there have been 100 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 21, 2023
@openjdk openjdk bot closed this Nov 21, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 21, 2023
@openjdk
Copy link

openjdk bot commented Nov 21, 2023

@dholmes-ora @dlunde Pushed as commit 9232070.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
4 participants