Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8319542: Fix boundaries of region to be tested with os::is_readable_range #16676

Closed
wants to merge 1 commit into from

Conversation

TOatGithub
Copy link
Contributor

@TOatGithub TOatGithub commented Nov 15, 2023

PR #16381 was already closed when it became obvious that usage of os::is_readable_range() was slightly wrong:

the " - 1" looks wrong here, because is_readable_range() checks for < to, not <= to.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8319542: Fix boundaries of region to be tested with os::is_readable_range (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16676/head:pull/16676
$ git checkout pull/16676

Update a local copy of the PR:
$ git checkout pull/16676
$ git pull https://git.openjdk.org/jdk.git pull/16676/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16676

View PR using the GUI difftool:
$ git pr show -t 16676

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16676.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 15, 2023

👋 Welcome back TOatGithub! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@TOatGithub
Copy link
Contributor Author

/label add hotspot

@openjdk openjdk bot added rfr Pull request is ready for review hotspot hotspot-dev@openjdk.org labels Nov 15, 2023
@openjdk
Copy link

openjdk bot commented Nov 15, 2023

@TOatGithub
The hotspot label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Nov 15, 2023

Webrevs

@TOatGithub
Copy link
Contributor Author

@dean-long : Hi, just wanted to bring this to your attention...
Thomas

Copy link
Member

@dean-long dean-long left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Nov 15, 2023

@TOatGithub This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8319542: Fix boundaries of region to be tested with os::is_readable_range

Reviewed-by: dlong, clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 155 new commits pushed to the master branch:

  • c36ec2c: 8316653: Large NMethodSizeLimit triggers assert during C1 code buffer allocation
  • 2db9ea9: 8317723: C2: CountedLoopEndNodes and Zero Trip Guards are wrongly treated as Runtime Predicate
  • eaa4417: 8319301: Static analysis warnings after JDK-8318016
  • 3452210: 8283140: Remove unused encoding classes/operands from x86_64.ad
  • f0b7eb5: 8304020: Speed up test/jdk/java/util/zip/ZipFile/TestTooManyEntries.java and clarify its purpose
  • ffa35d8: 8301997: Move method resolution information out of the cpCache
  • 891d8cf: 8319986: Invalid/inconsistent description and example for DateFormat
  • 536b1ce: 8320130: Problemlist 2 vmTestbase/nsk/jdi/StepRequest/addClassFilter_rt tests with Xcomp
  • 0bda467: 8319187: Add three eMudhra emSign roots
  • 3c6ffca: 8318219: RISC-V: C2 ExpandBits
  • ... and 145 more: https://git.openjdk.org/jdk/compare/7a7b1e5a920d71ab717d8993c9258a01f1074a48...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dean-long, @RealCLanger) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 15, 2023
@TOatGithub
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 16, 2023
@openjdk
Copy link

openjdk bot commented Nov 16, 2023

@TOatGithub
Your change (at version 9d8a531) is now ready to be sponsored by a Committer.

@dean-long
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 16, 2023

Going to push as commit b4c2d1c.
Since your change was applied there have been 155 commits pushed to the master branch:

  • c36ec2c: 8316653: Large NMethodSizeLimit triggers assert during C1 code buffer allocation
  • 2db9ea9: 8317723: C2: CountedLoopEndNodes and Zero Trip Guards are wrongly treated as Runtime Predicate
  • eaa4417: 8319301: Static analysis warnings after JDK-8318016
  • 3452210: 8283140: Remove unused encoding classes/operands from x86_64.ad
  • f0b7eb5: 8304020: Speed up test/jdk/java/util/zip/ZipFile/TestTooManyEntries.java and clarify its purpose
  • ffa35d8: 8301997: Move method resolution information out of the cpCache
  • 891d8cf: 8319986: Invalid/inconsistent description and example for DateFormat
  • 536b1ce: 8320130: Problemlist 2 vmTestbase/nsk/jdi/StepRequest/addClassFilter_rt tests with Xcomp
  • 0bda467: 8319187: Add three eMudhra emSign roots
  • 3c6ffca: 8318219: RISC-V: C2 ExpandBits
  • ... and 145 more: https://git.openjdk.org/jdk/compare/7a7b1e5a920d71ab717d8993c9258a01f1074a48...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 16, 2023
@openjdk openjdk bot closed this Nov 16, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 16, 2023
@openjdk
Copy link

openjdk bot commented Nov 16, 2023

@dean-long @TOatGithub Pushed as commit b4c2d1c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
3 participants