Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8320199: Fix HTML 5 errors in java.math.BigInteger #16679

Closed
wants to merge 1 commit into from

Conversation

bplb
Copy link
Member

@bplb bplb commented Nov 15, 2023

Clean up HTML error due to nested anchor (<a>) elements.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8320199: Fix HTML 5 errors in java.math.BigInteger (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16679/head:pull/16679
$ git checkout pull/16679

Update a local copy of the PR:
$ git checkout pull/16679
$ git pull https://git.openjdk.org/jdk.git pull/16679/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16679

View PR using the GUI difftool:
$ git pr show -t 16679

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16679.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 15, 2023

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@bplb
Copy link
Member Author

bplb commented Nov 15, 2023

HTML Tidy (tidy -e) output after 6cc6f8b:

Info: Document content looks like HTML5
No warnings or errors were found.

Generated HTML looks okay and the link to the BigInteger anchor from BigDecimal works.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 15, 2023
@openjdk
Copy link

openjdk bot commented Nov 15, 2023

@bplb The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Nov 15, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 15, 2023

Webrevs

Copy link
Member

@naotoj naotoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

@openjdk
Copy link

openjdk bot commented Nov 15, 2023

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8320199: Fix HTML 5 errors in java.math.BigInteger

Reviewed-by: naoto, darcy, lancea, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 15, 2023
Copy link
Member

@jddarcy jddarcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; thanks for fixing this.

@bplb
Copy link
Member Author

bplb commented Nov 16, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Nov 16, 2023

Going to push as commit 9727f4b.
Since your change was applied there have been 18 commits pushed to the master branch:

  • d6aa7c8: 8314621: ClassNotFoundException due to lambda reference to elided anonymous inner class
  • 52e2878: 8319987: compilation of sealed classes leads to infinite recursion
  • b05e69f: 8320209: VectorMaskGen clobbers rflags on x86_64
  • f3ed275: 8319103: Popups that request focus are not shown on Linux with Wayland
  • 9e7a3ae: 8319630: Monitor final audit log lacks separator
  • 87be6b6: 8318757: VM_ThreadDump asserts in interleaved ObjectMonitor::deflate_monitor calls
  • 9faead1: 8319927: Log that IEEE rounding mode was corrupted by loading a library
  • f33c874: 8319764: C2 compilation asserts during incremental inlining because Phi input is out of bounds
  • 6868b37: 8318826: C2: "Bad graph detected in build_loop_late" with incremental inlining
  • 1d96886: 8319531: FileServerHandler::discardRequestBody could be improved
  • ... and 8 more: https://git.openjdk.org/jdk/compare/ffa35d8cf181cfbcb54497e997dbd18a9b62b97e...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 16, 2023
@openjdk openjdk bot closed this Nov 16, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 16, 2023
@openjdk
Copy link

openjdk bot commented Nov 16, 2023

@bplb Pushed as commit 9727f4b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@bplb bplb deleted the BigInteger-HTML5-8320199 branch November 16, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
5 participants