-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8320199: Fix HTML 5 errors in java.math.BigInteger #16679
Conversation
👋 Welcome back bpb! A progress list of the required criteria for merging this PR into |
HTML Tidy (
Generated HTML looks okay and the link to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine
@bplb This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good; thanks for fixing this.
/integrate |
Going to push as commit 9727f4b.
Your commit was automatically rebased without conflicts. |
Clean up HTML error due to nested anchor (
<a>
) elements.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16679/head:pull/16679
$ git checkout pull/16679
Update a local copy of the PR:
$ git checkout pull/16679
$ git pull https://git.openjdk.org/jdk.git pull/16679/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 16679
View PR using the GUI difftool:
$ git pr show -t 16679
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16679.diff
Webrev
Link to Webrev Comment