8254996: make jdk.net.UnixDomainPrincipal a record class

[pconcannon]

Hi,

Could someone please review my code for JDK-8254996: 'make jdk.net.UnixDomainPrincipal a record class'?

jdk.net.UnixDomainPrincipal is a simple immutable data class that requires boilerplate methods for access. However, these methods and fields are susceptible to trivial mistakes and add to the verbosity of the class.
This fix replaces the data class with a record class, a new type in JDK 16, making the code more concise and easier to maintain. This code is binary compatible with the original. For the generated API doc change, please refer to the specdiff attached to the CSR.

CSR : https://bugs.openjdk.java.net/browse/JDK-8257823

Kind regards,
Patrick

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8254996: make jdk.net.UnixDomainPrincipal a record class

Reviewers

• Daniel Fuchs (@dfuch - Reviewer) ⚠️ Review applies to 7dace76
• Michael McMahon (@Michael-Mc-Mahon - Reviewer) ⚠️ Review applies to 7dace76

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1668/head:pull/1668
$ git checkout pull/1668

[bridgekeeper]

👋 Welcome back pconcannon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@pconcannon The following label will be automatically applied to this pull request:

• net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (b00569d)
• 01: Full - Incremental (2adf145)
• 00: Full (7dace76)

[dfuch]

That looks fine to me Patrick. First top-level record class in the JDK!

[openjdk]

@pconcannon This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254996: make jdk.net.UnixDomainPrincipal a record class

Reviewed-by: dfuchs, michaelm

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[Michael-Mc-Mahon]

/csr needed

[openjdk]

@Michael-Mc-Mahon this pull request will not be integrated until the CSR request JDK-8257823 for issue JDK-8254996 has been approved.

[pconcannon]

/integrate

[openjdk]

@pconcannon Pushed as commit 6dd06ad.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.