Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8242258: (jrtfs) Path::toUri throws AssertionError for malformed input #1669

Closed
wants to merge 2 commits into from
Closed

8242258: (jrtfs) Path::toUri throws AssertionError for malformed input #1669

wants to merge 2 commits into from

Conversation

@sundararajana
Copy link
Member

@sundararajana sundararajana commented Dec 7, 2020

Safe URI encode logic adopted from UnixUriUtils.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8242258: (jrtfs) Path::toUri throws AssertionError for malformed input

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1669/head:pull/1669
$ git checkout pull/1669

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 7, 2020

👋 Welcome back sundar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Dec 7, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 7, 2020

@sundararajana The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs label Dec 7, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 7, 2020

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Dec 8, 2020

@sundararajana This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8242258: (jrtfs) Path::toUri throws AssertionError for malformed input

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

  • 500ab45: 8257769: Cipher.getParameters() throws NPE for ChaCha20-Poly1305
  • 6ff18e3: 8257855: Example SafeVarargsNotApplicableToRecordAccessors breaks test tools/javac/diags/CheckExamples.java
  • cef606f: 8253762: JFR: getField(String) should be able to access subfields
  • 39b8a2e: 8257670: sun/security/ssl/SSLSocketImpl/SSLSocketLeak.java reports leaks
  • c43c224: 8257796: [TESTBUG] TestUseSHA512IntrinsicsOptionOnSupportedCPU.java fails on x86_32
  • 62c7788: 8257211: C2: Enable call devirtualization during post-parse phase
  • 149a02f: 8257572: Deprecate the archaic signal-chaining interfaces: sigset and signal
  • f92745d: 8257718: LogCompilation: late_inline doesnt work right for JDK 8 logs
  • 6937d9f: 8257799: Update JLS cross-references in java.compiler
  • a5297bd: 8254939: macOS: unused function 'replicate4_imm'
  • ... and 11 more: https://git.openjdk.java.net/jdk/compare/ecd7e476f838d6585d352488905a671bf2e41df3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Dec 8, 2020
@sundararajana
Copy link
Member Author

@sundararajana sundararajana commented Dec 8, 2020

/integrate

@openjdk openjdk bot closed this Dec 8, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 8, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 8, 2020

@sundararajana Since your change was applied there have been 25 commits pushed to the master branch:

  • 52ab721: 8254733: HotSpot Style Guide should permit using range-based for loops
  • 1d0adbb: 8253644: C2: assert(skeleton_predicate_has_opaque(iff)) failed: unexpected
  • 51ac376: 8256411: Based anonymous classes have a weird end position
  • 0b6b6eb: 8257813: [redo] C2: Filter type in PhiNode::Value() for induction variables of trip-counted integer loops
  • 500ab45: 8257769: Cipher.getParameters() throws NPE for ChaCha20-Poly1305
  • 6ff18e3: 8257855: Example SafeVarargsNotApplicableToRecordAccessors breaks test tools/javac/diags/CheckExamples.java
  • cef606f: 8253762: JFR: getField(String) should be able to access subfields
  • 39b8a2e: 8257670: sun/security/ssl/SSLSocketImpl/SSLSocketLeak.java reports leaks
  • c43c224: 8257796: [TESTBUG] TestUseSHA512IntrinsicsOptionOnSupportedCPU.java fails on x86_32
  • 62c7788: 8257211: C2: Enable call devirtualization during post-parse phase
  • ... and 15 more: https://git.openjdk.java.net/jdk/compare/ecd7e476f838d6585d352488905a671bf2e41df3...master

Your commit was automatically rebased without conflicts.

Pushed as commit d2b6619.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sundararajana sundararajana deleted the JDK-8242258 branch Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants