Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8319124: Update XML Security for Java to 3.0.3 #16691

Closed
wants to merge 1 commit into from

Conversation

wangweij
Copy link
Contributor

@wangweij wangweij commented Nov 16, 2023

Update XMLDsig implementation to match Apache Santuario 3.0.3.

Changes include (significance in descending order):

  • SignatureMethod.java: new signature method URIs defined
  • SignatureBaseRSA.java: SignatureBaseRSAPSS and refactoring
  • JCEMapper.java: use of ThreadLocal
  • DigestorOutputStream.java: one synchronized method
  • XMLUtils.java: renames, one new method not used anywhere, some log change
  • Init.java: some refactoring
  • DOMSignatureMethod.java: new MGF1 methods, some refactoring
  • DOMXMLSignatureFactory.java: new signature methods
  • santuario.md, XMLDSigRI.java: bump to 3.0.3
  • DOMXMLSignature.java: some finals
  • NameSpaceSymbTable.java: renames
  • Base64.java: no longer final
  • Others: reorder imports, add @Override, foreach, diamond operators

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8320218 to be approved

Issues

  • JDK-8319124: Update XML Security for Java to 3.0.3 (Enhancement - P3)
  • JDK-8320218: Update XML Security for Java to 3.0.3 (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16691/head:pull/16691
$ git checkout pull/16691

Update a local copy of the PR:
$ git checkout pull/16691
$ git pull https://git.openjdk.org/jdk.git pull/16691/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16691

View PR using the GUI difftool:
$ git pr show -t 16691

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16691.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 16, 2023

👋 Welcome back weijun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added csr Pull request needs approved CSR before integration rfr Pull request is ready for review labels Nov 16, 2023
@openjdk
Copy link

openjdk bot commented Nov 16, 2023

@wangweij The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Nov 16, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 16, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 17, 2023

@wangweij This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8319124: Update XML Security for Java to 3.0.3

Reviewed-by: mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 120 new commits pushed to the master branch:

  • 1588dd9: 8319567: Update java/lang/invoke tests to support vm flags
  • 9727f4b: 8320199: Fix HTML 5 errors in java.math.BigInteger
  • d6aa7c8: 8314621: ClassNotFoundException due to lambda reference to elided anonymous inner class
  • 52e2878: 8319987: compilation of sealed classes leads to infinite recursion
  • b05e69f: 8320209: VectorMaskGen clobbers rflags on x86_64
  • f3ed275: 8319103: Popups that request focus are not shown on Linux with Wayland
  • 9e7a3ae: 8319630: Monitor final audit log lacks separator
  • 87be6b6: 8318757: VM_ThreadDump asserts in interleaved ObjectMonitor::deflate_monitor calls
  • 9faead1: 8319927: Log that IEEE rounding mode was corrupted by loading a library
  • f33c874: 8319764: C2 compilation asserts during incremental inlining because Phi input is out of bounds
  • ... and 110 more: https://git.openjdk.org/jdk/compare/4a0ad462abc2e1c92ea9b9af8333badc0df1afa9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed csr Pull request needs approved CSR before integration labels Nov 17, 2023
@wangweij
Copy link
Contributor Author

/approval request import

@openjdk
Copy link

openjdk bot commented Nov 17, 2023

@wangweij Changes in this repository do not require maintainer approval.

@wangweij
Copy link
Contributor Author

/reviewers 99

@openjdk
Copy link

openjdk bot commented Nov 17, 2023

@wangweij Usage: /reviewers <n> [<role>] where <n> is the number of required reviewers. If role is set, the reviewers need to have that project role. If omitted, role defaults to authors.
Cannot increase the required number of reviewers above 10 (requested: 99)

@wangweij
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 21, 2023

Going to push as commit 1c0bd81.
Since your change was applied there have been 172 commits pushed to the master branch:

  • 61d81d6: 8317742: ISO Standard Date Format implementation consistency on DateTimeFormatter and String.format
  • c4aba87: 8320272: Make method_entry_barrier address shared
  • 9311749: 8320526: Use title case in building.md
  • 9598ff8: 8315969: compiler/rangechecks/TestRangeCheckHoistingScaledIV.java: make flagless
  • 53eb6f1: 8187591: -Werror turns incubator module warning to an error
  • 570dffb: 8310807: java/nio/channels/DatagramChannel/Connect.java timed out
  • 21a59b9: 8282726: java/net/vthread/BlockingSocketOps.java timeout/hang intermittently on Windows
  • 9232070: 8318480: Obsolete UseCounterDecay and remove CounterDecayMinIntervalLength
  • e055fae: 8264425: Update building.md on non-English locales on Windows
  • c4aee66: 8320222: Wrong bytecode accepted, and StackMap table generated
  • ... and 162 more: https://git.openjdk.org/jdk/compare/4a0ad462abc2e1c92ea9b9af8333badc0df1afa9...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 21, 2023
@openjdk openjdk bot closed this Nov 21, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 21, 2023
@openjdk
Copy link

openjdk bot commented Nov 21, 2023

@wangweij Pushed as commit 1c0bd81.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@wangweij wangweij deleted the 8319124 branch November 21, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
2 participants