8264425: Update building.md on non-English locales on Windows

[magicus]

Update the build documentation to reflect the fact that non-English locales are only supported on a "best effort" principle, and add instructions how to install the necessary language pack to Visual Studio.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8264425: Update building.md on non-English locales on Windows (Bug - P3)

Reviewers

• Naoto Sato (@naotoj - Reviewer) ⚠️ Review applies to 6c1cd3b5
• Erik Joelsson (@erikj79 - Reviewer) ⚠️ Review applies to 6c1cd3b5

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16694/head:pull/16694
$ git checkout pull/16694

Update a local copy of the PR:
$ git checkout pull/16694
$ git pull https://git.openjdk.org/jdk.git pull/16694/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16694

View PR using the GUI difftool:
$ git pr show -t 16694

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16694.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ihse! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@magicus The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 03: Full (af204532)
• 02: Full - Incremental (6c1cd3b5)
• 01: Full - Incremental (038407b3)
• 00: Full (fec451ca)

[magicus]

The entire markdown file with the changes can be viewed here:
https://github.com/magicus/jdk/blob/readme-locale/doc/building.md#windows

[naotoj]

Thanks for the changes @magicus. This version looks very good in terms of the Windows locale environment.

[openjdk]

@magicus this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout readme-locale
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

[magicus]

/integrate

[openjdk]

@magicus This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264425: Update building.md on non-English locales on Windows

Reviewed-by: naoto, erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

Going to push as commit e055fae.
Since your change was applied there has been 1 commit pushed to the master branch:

• c4aee66: 8320222: Wrong bytecode accepted, and StackMap table generated

Your commit was automatically rebased without conflicts.

[openjdk]

@magicus Pushed as commit e055fae.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.