-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8253146: C2: Purge unused MachCallNode::_arg_size field #167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
@shipilev The following label will be automatically applied to this pull request: When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the |
This touches |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@shipilev This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements After integration, the commit message will be:
Since the source branch of this PR was last updated there have been 15 commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge ➡️ To integrate this PR with the above commit message to the |
/integrate |
@shipilev Since your change was applied there have been 15 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 7c564e1. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
While doing changes in related code, noticed that
MachCallNode::_arg_size
is computed needlessly, taking memory without a good reason. Let's purge it.Testing: text search for _argsize; Linux x86_64 {release,fastdebug,slowdebug} builds; Linux x86_64 tier1; Linux ppc64 fastdebug build
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/167/head:pull/167
$ git checkout pull/167