Skip to content

8253146: C2: Purge unused MachCallNode::_arg_size field #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Sep 15, 2020

While doing changes in related code, noticed that MachCallNode::_arg_size is computed needlessly, taking memory without a good reason. Let's purge it.

Testing: text search for _argsize; Linux x86_64 {release,fastdebug,slowdebug} builds; Linux x86_64 tier1; Linux ppc64 fastdebug build


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8253146: C2: Purge unused MachCallNode::_arg_size field

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/167/head:pull/167
$ git checkout pull/167

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 15, 2020

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 15, 2020
@openjdk
Copy link

openjdk bot commented Sep 15, 2020

@shipilev The following label will be automatically applied to this pull request: hotspot-compiler.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Sep 15, 2020
@shipilev
Copy link
Member Author

This touches ppc.ad, attention @GoeLin, @TheRealMDoerr.

@mlbridge
Copy link

mlbridge bot commented Sep 15, 2020

Webrevs

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Sep 15, 2020

@shipilev This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8253146: C2: Purge unused MachCallNode::_arg_size field

Reviewed-by: thartmann, adityam
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 15 commits pushed to the master branch:

  • 2caa20a: 8250668: Clean up method_oop names in adlc
  • 57f92d2: 8220483: Calendar.setTime(Date date) throws NPE with Date date = null
  • 65bfe09: 8253147: The javax/swing/JPopupMenu/7154841/bug7154841.java fail on big screens
  • fc36328: 8253034: Update symbol generation to accomodate Git as the SCM
  • 4020682: 8172366: Support SHA-3 based signatures
  • 46598c8: 8253177: outputStream not declared in markWord.hpp
  • 5191f31: 8251495: Remove the implNote in the DOM package description added by JDK-8249643
  • 65d6c10: 8252933: com.sun.tools.jdi.ObjectReferenceImpl#validateAssignment always requests referenceType
  • 74851c5: 8253169: [BACKOUT] Improve large object handling during evacuation
  • b5620a3: 8253155: Minor cleanups and Javadoc fixes for LdapDnsProvider of java.naming
  • ... and 5 more: https://git.openjdk.java.net/jdk/compare/3f455f09dc738b7c76210c1080df2aaa8e19a19d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 2caa20a76d849e26872bb340152bbed94b428fe1.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 15, 2020
@shipilev
Copy link
Member Author

/integrate

@openjdk openjdk bot closed this Sep 16, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated labels Sep 16, 2020
@openjdk
Copy link

openjdk bot commented Sep 16, 2020

@shipilev Since your change was applied there have been 15 commits pushed to the master branch:

  • 2caa20a: 8250668: Clean up method_oop names in adlc
  • 57f92d2: 8220483: Calendar.setTime(Date date) throws NPE with Date date = null
  • 65bfe09: 8253147: The javax/swing/JPopupMenu/7154841/bug7154841.java fail on big screens
  • fc36328: 8253034: Update symbol generation to accomodate Git as the SCM
  • 4020682: 8172366: Support SHA-3 based signatures
  • 46598c8: 8253177: outputStream not declared in markWord.hpp
  • 5191f31: 8251495: Remove the implNote in the DOM package description added by JDK-8249643
  • 65d6c10: 8252933: com.sun.tools.jdi.ObjectReferenceImpl#validateAssignment always requests referenceType
  • 74851c5: 8253169: [BACKOUT] Improve large object handling during evacuation
  • b5620a3: 8253155: Minor cleanups and Javadoc fixes for LdapDnsProvider of java.naming
  • ... and 5 more: https://git.openjdk.java.net/jdk/compare/3f455f09dc738b7c76210c1080df2aaa8e19a19d...master

Your commit was automatically rebased without conflicts.

Pushed as commit 7c564e1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk openjdk bot removed the rfr Pull request is ready for review label Sep 16, 2020
@shipilev shipilev deleted the JDK-8253146 branch September 16, 2020 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants