Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8257639: Update usage of "type" terminology in java.lang.Enum & java.lang.Record #1670

Closed
wants to merge 4 commits into from

Conversation

FrauBoes
Copy link
Member

@FrauBoes FrauBoes commented Dec 7, 2020

This change applies a stricter semantic distinction of 'type' versus 'class and interface'. This is based on the JLS changes described in the "Consistent Class and Interface Terminology" document: https://download.java.net/java/early_access/jdk16/docs/specs/class-terminology-jls.html.

The following rules were applied:

  • 'class' and/or 'interface' are used when referring to the class/interface itself
  • 'type' is used when referring to the type of a variable or expression

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8257639: Update usage of "type" terminology in java.lang.Enum & java.lang.Record

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1670/head:pull/1670
$ git checkout pull/1670

@FrauBoes
Copy link
Member Author

FrauBoes commented Dec 7, 2020

/csr needed

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 7, 2020

👋 Welcome back jboes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added rfr Pull request is ready for review csr Pull request needs approved CSR before integration labels Dec 7, 2020
@openjdk
Copy link

openjdk bot commented Dec 7, 2020

@FrauBoes this pull request will not be integrated until the CSR request JDK-8257844 for issue JDK-8257639 has been approved.

@openjdk
Copy link

openjdk bot commented Dec 7, 2020

@FrauBoes The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Dec 7, 2020
@mlbridge
Copy link

mlbridge bot commented Dec 7, 2020

Webrevs

@openjdk openjdk bot removed the csr Pull request needs approved CSR before integration label Dec 8, 2020
@openjdk
Copy link

openjdk bot commented Dec 8, 2020

@FrauBoes This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8257639: Update usage of "type" terminology in java.lang.Enum & java.lang.Record

Reviewed-by: chegar, dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 28 new commits pushed to the master branch:

  • 936a7ac: 8252797: Non-PCH build fails on Ubuntu 16.4 when building with gtests
  • d0c5265: 8256149: Weird AST structure for incomplete member select
  • a708024: 8257194: Add 'foreign linker API' in 'jdk.incubator.foreign' module desc/summary
  • 35e8153: 8257848: -XX:CompileCommand=blackhole,* should be diagnostic
  • d2b6619: 8242258: (jrtfs) Path::toUri throws AssertionError for malformed input
  • 52ab721: 8254733: HotSpot Style Guide should permit using range-based for loops
  • 1d0adbb: 8253644: C2: assert(skeleton_predicate_has_opaque(iff)) failed: unexpected
  • 51ac376: 8256411: Based anonymous classes have a weird end position
  • 0b6b6eb: 8257813: [redo] C2: Filter type in PhiNode::Value() for induction variables of trip-counted integer loops
  • 500ab45: 8257769: Cipher.getParameters() throws NPE for ChaCha20-Poly1305
  • ... and 18 more: https://git.openjdk.java.net/jdk/compare/2c04fc02c929a117ce620ac70e3b957c4afc3c40...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 8, 2020
@FrauBoes
Copy link
Member Author

FrauBoes commented Dec 9, 2020

/integrate

@openjdk openjdk bot closed this Dec 9, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 9, 2020
@openjdk
Copy link

openjdk bot commented Dec 9, 2020

@FrauBoes Since your change was applied there have been 45 commits pushed to the master branch:

  • b4615c6: 8256580: Fault in new grid display
  • df55ecd: 8257794: Zero: assert(istate->_stack_limit == istate->_thread->last_Java_sp() + 1) failed: wrong on Linux/x86_32
  • fae7961: 8257884: Re-enable sun/security/ssl/SSLSocketImpl/SSLSocketLeak.java as automatic test
  • 79f1dfb: 8255987: JDI tests fail with com.sun.jdi.ObjectCollectedException
  • 9ce3d80: 8257887: java/foreign/TestSegments.java test fails on 32-bit after JDK-8257186
  • 10da767: 8257847: Tiered should publish MDO data pointer for interpreter after profile start
  • 2a62d5d: 8256917: Use combo @returns tag in java.compiler javadoc
  • b29f9cd: 8075778: Add javadoc tag to avoid duplication of return information in simple situations.
  • 48d8650: 8257845: Integrate JEP 390
  • ed4c4ee: 8256299: Implement JEP 396: Strongly Encapsulate JDK Internals by Default
  • ... and 35 more: https://git.openjdk.java.net/jdk/compare/2c04fc02c929a117ce620ac70e3b957c4afc3c40...master

Your commit was automatically rebased without conflicts.

Pushed as commit 5bdce9b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants