8319571: Update jni/nullCaller/NullCallerTest.java to accept flags or mark as flagless

[tprinzing]

Updated to use ProcessTool helper class to run test passing flags.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8319571: Update jni/nullCaller/NullCallerTest.java to accept flags or mark as flagless (Sub-task - P4)

Reviewers

• Mandy Chung (@mlchung - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16711/head:pull/16711
$ git checkout pull/16711

Update a local copy of the PR:
$ git checkout pull/16711
$ git pull https://git.openjdk.org/jdk.git pull/16711/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16711

View PR using the GUI difftool:
$ git pr show -t 16711

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16711.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back tprinzing! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tprinzing To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels

• build
• client
• compiler
• core-libs
• graal
• hotspot
• hotspot-compiler
• hotspot-gc
• hotspot-jfr
• hotspot-runtime
• i18n
• ide-support
• javadoc
• jdk
• jmx
• kulla
• net
• nio
• security
• serviceability
• shenandoah

[tprinzing]

/label core-libs

[openjdk]

@tprinzing
The core-libs label was successfully added.

[mlbridge]

Webrevs

• 01: Full - Incremental (b947469b)
• 00: Full (bbcbb810)

[mlchung]

This one is similar to JDK-8319568 that simplified CallerAccessTest to call ProcessTools::createNativeTestProcessBuilder as the test can run with VM flags. Is this same change applicable to NullCallerTest.java?

[mlchung]

It'd help if the PR description reflects what this change is. It's no longer made VM flagless.

[openjdk]

@tprinzing This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8319571: Update jni/nullCaller/NullCallerTest.java to accept flags or mark as flagless

Reviewed-by: mchung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 260 new commits pushed to the master branch:

• 519ecd3: 8319413: Start of release updates for JDK 23
• 86f9b3f: 8319313: G1: Rename G1EvacFailureInjector appropriately
• a7f6016: 8320370: NMT: Change MallocMemorySnapshot to simplify code.
• 58530f4: 8321223: Implementation of Scoped Values (Second Preview)
• 2f9e70e: 8321001: RISC-V: C2 SignumVF
• de95259: 8316454: JFR break locale settings
• c42535f: 8321470: ThreadLocal.nextHashCode can be static final
• 42bb852: 8321467: MemorySegment.setString(long, String, Charset) throws IAE(Misaligned access)
• c087e91: 8321505: JFR: Update views
• ead4fb1: 8321519: Typo in exception message
• ... and 250 more: https://git.openjdk.org/jdk/compare/61d81d6496a38e43a6039abc041b67626f06f5c9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mlchung) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[tprinzing]

/integrate

[openjdk]

@tprinzing
Your change (at version b947469) is now ready to be sponsored by a Committer.

[bridgekeeper]

@tprinzing This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[mlchung]

/sponsor

[openjdk]

Going to push as commit b78896b.
Since your change was applied there have been 560 commits pushed to the master branch:

• e10d140: 8321712: C2: "failed: Multiple uses of register" in C2_MacroAssembler::vminmax_fp
• c2e77e2: 8319128: sun/security/pkcs11 tests fail on OL 7.9 aarch64
• 9fd855e: 8322971: KEM.getInstance() should check if a 3rd-party security provider is signed
• b8ae4a8: 8320890: [AIX] Find a better way to mimic dl handle equality
• e5aed6b: 8323276: StressDirListings.java fails on AIX
• b922f8d: 8319793: C2 compilation fails with "Bad graph detected in build_loop_late" after JDK-8279888
• 35e9662: 8314515: java/util/concurrent/SynchronousQueue/Fairness.java failed with "Error: fair=false i=8 j=0"
• cb1d25f: 8323330: [BACKOUT] JDK-8276809: java/awt/font/JNICheck/FreeTypeScalerJNICheck.java shows JNI warning on Windows
• 2b7fc05: 8264102: JTable Keyboards Navigation differs with Test Instructions.
• af942a6: 8323188: JFR: Needless RESOURCE_ARRAY when sending EventOSInformation
• ... and 550 more: https://git.openjdk.org/jdk/compare/61d81d6496a38e43a6039abc041b67626f06f5c9...master

Your commit was automatically rebased without conflicts.

[openjdk]

@mlchung @tprinzing Pushed as commit b78896b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.