-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8320349: Simplify FileChooserSymLinkTest.java by using single-window testUI #16718
8320349: Simplify FileChooserSymLinkTest.java by using single-window testUI #16718
Conversation
👋 Welcome back aivanov! A progress list of the required criteria for merging this PR into |
@aivanov-jdk The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout 8320349-singleTestUI-FileChooserSymLinkTest
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
@aivanov-jdk This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit b1cb374. |
@aivanov-jdk Pushed as commit b1cb374. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Update
FileChooserSymLinkTest.java
to simplify its implementation by replacingList<Window>
withJFrame
of itscreateTestUI
which now usesPassFailJFrame.Builder testUI(PassFailJFrame.WindowCreator)
instead ofPassFailJFrame.Builder testUI(PassFailJFrame.WindowListCreator)
.The test works correctly with and without the update.
This PR depends on #16717.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16718/head:pull/16718
$ git checkout pull/16718
Update a local copy of the PR:
$ git checkout pull/16718
$ git pull https://git.openjdk.org/jdk.git pull/16718/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 16718
View PR using the GUI difftool:
$ git pr show -t 16718
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16718.diff
Webrev
Link to Webrev Comment