8320348: test/jdk/java/io/File/GetAbsolutePath.windowsDriveRelative fails if working directory is not on drive C

[bplb]

The method windowsDriveRelative of the test java/io/File/GetAbsolutePath was incorrectly translated from its previous version to the current JUnit 5 version.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8320348: test/jdk/java/io/File/GetAbsolutePath.windowsDriveRelative fails if working directory is not on drive C (Bug - P4)

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)
• Matthias Baesken (@MBaesken - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16720/head:pull/16720
$ git checkout pull/16720

Update a local copy of the PR:
$ git checkout pull/16720
$ git pull https://git.openjdk.org/jdk.git pull/16720/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16720

View PR using the GUI difftool:
$ git pr show -t 16720

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16720.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@bplb The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (f5391d7e)

[bplb]

@MBaesken I would appreciate it if you would try out this proposed change to see whether it fixes the problem that you reported. Thanks!

[AlanBateman]

The test fix looks okay but the title on the issue is confusing, it suggests that File.getAbsolutePath is broken so I've renamed the JBS issue, hope that is okay.

[MBaesken]

@MBaesken I would appreciate it if you would try out this proposed change
to see whether it fixes the problem that you reported. Thanks!

Hi Brian, I added your patch to our tests.

[MBaesken]

@MBaesken I would appreciate it if you would try out this proposed change
to see whether it fixes the problem that you reported. Thanks!

Hi Brian, I added your patch to our tests.

After adding the patch, the errors seen before in our test runs are gone. Thanks for the patch !

[openjdk]

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8320348: test/jdk/java/io/File/GetAbsolutePath.windowsDriveRelative fails if working directory is not on drive C

Reviewed-by: alanb, mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 45 new commits pushed to the master branch:

• 6e86904: 8319973: AArch64: Save and restore FPCR in the call stub
• 04fd17e: 8320410: Reflow markdown in building.md
• 7f23110: 8319928: Exceptions thrown by cleanup actions should be handled correctly
• a6098e4: 8320280: RISC-V: Avoid passing t0 as temp register to MacroAssembler::lightweight_lock/unlock
• 60c8d9c: 8320300: Adjust hs_err output in malloc/mmap error cases
• 9f6a4a3: 8320386: Remove java/nio/channels/vthread/BlockingChannelOps.java#direct-register from ProblemList
• db1d823: 8320168: handle setsocktopt return values
• 6c5e15c: 8316557: Make fields final in 'sun.util' package
• de51aa1: 8283214: [macos] Screen magnifier does not show the magnified text for JcomboBox
• 179f505: 8320361: Doc error in RemoteRecordingStream.java
• ... and 35 more: https://git.openjdk.org/jdk/compare/ffa35d8cf181cfbcb54497e997dbd18a9b62b97e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[bplb]

After adding the patch, the errors seen before in our test runs are gone. Thanks for the patch !

Thanks for verifying!

[bplb]

I've renamed the JBS issue, hope that is okay.

No problem: this is more apt.

[bplb]

/integrate

[openjdk]

Going to push as commit 32098ce.
Since your change was applied there have been 49 commits pushed to the master branch:

• a2c0fa6: 8320372: test/jdk/sun/security/x509/DNSName/LeadingPeriod.java validity check failed
• 3aefd1c: 8320234: Merge doclint.Env.AccessKind with tool.AccessKind
• d6d7bdc: 8319817: Charset constructor should make defensive copy of aliases
• 0712b22: 8320147: Remove DumpSharedSpaces
• 6e86904: 8319973: AArch64: Save and restore FPCR in the call stub
• 04fd17e: 8320410: Reflow markdown in building.md
• 7f23110: 8319928: Exceptions thrown by cleanup actions should be handled correctly
• a6098e4: 8320280: RISC-V: Avoid passing t0 as temp register to MacroAssembler::lightweight_lock/unlock
• 60c8d9c: 8320300: Adjust hs_err output in malloc/mmap error cases
• 9f6a4a3: 8320386: Remove java/nio/channels/vthread/BlockingChannelOps.java#direct-register from ProblemList
• ... and 39 more: https://git.openjdk.org/jdk/compare/ffa35d8cf181cfbcb54497e997dbd18a9b62b97e...master

Your commit was automatically rebased without conflicts.

[openjdk]

@bplb Pushed as commit 32098ce.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.