New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8257817: Shenandoah: Don't race with conc-weak-in-progress flag in weak-LRB #1673
Conversation
👋 Welcome back zgu! A progress list of the required criteria for merging this PR into |
@zhengyu123 The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Might want to see in a follow-up if binding conc-roots-flag to should_do_class_unloading() is sane.
@zhengyu123 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 7 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Thanks for reviewing. There is already a RFE (JDK-8255837) to clean can/should_do_xxx up, as part of ongoing refactoring. |
/integrate |
@zhengyu123 Since your change was applied there have been 7 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 395b6bd. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
After concurrent weak root processing, it should perform handshake first to ensure there are no dirty loads (loads have yet processed by barriers) in Java thread, before it resets conc-weak-root-in-progress flag.
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/1673/head:pull/1673
$ git checkout pull/1673