Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8320386: Remove java/nio/channels/vthread/BlockingChannelOps.java#direct-register from ProblemList #16732

Closed
wants to merge 1 commit into from

Conversation

djelinski
Copy link
Member

@djelinski djelinski commented Nov 20, 2023

The direct-register test variant was removed in c099cf5. The failing test case was also modified - the socket timeout is much shorter now, so even if the receive operation gets stuck for the full duration, the test will still pass.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8320386: Remove java/nio/channels/vthread/BlockingChannelOps.java#direct-register from ProblemList (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16732/head:pull/16732
$ git checkout pull/16732

Update a local copy of the PR:
$ git checkout pull/16732
$ git pull https://git.openjdk.org/jdk.git pull/16732/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16732

View PR using the GUI difftool:
$ git pr show -t 16732

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16732.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 20, 2023

👋 Welcome back djelinski! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8320386 8320386: Remove java/nio/channels/vthread/BlockingChannelOps.java#direct-register from ProblemList Nov 20, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 20, 2023
@openjdk
Copy link

openjdk bot commented Nov 20, 2023

@djelinski To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@djelinski
Copy link
Member Author

/label core-libs

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Nov 20, 2023
@openjdk
Copy link

openjdk bot commented Nov 20, 2023

@djelinski
The core-libs label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Nov 20, 2023

Webrevs

@AlanBateman
Copy link
Contributor

/label add nio

@openjdk openjdk bot added the nio nio-dev@openjdk.org label Nov 20, 2023
@openjdk
Copy link

openjdk bot commented Nov 20, 2023

@AlanBateman
The nio label was successfully added.

Copy link
Contributor

@AlanBateman AlanBateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this exclude list was missed with the poller update so the test id no longer matches. It's okay to remove now.

@openjdk
Copy link

openjdk bot commented Nov 20, 2023

@djelinski This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8320386: Remove java/nio/channels/vthread/BlockingChannelOps.java#direct-register from ProblemList

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 20, 2023
@djelinski
Copy link
Member Author

Thanks for the quick review. Given the trivial nature of this change, I'm going to integrate it now.

/integrate

@openjdk
Copy link

openjdk bot commented Nov 20, 2023

Going to push as commit 9f6a4a3.
Since your change was applied there has been 1 commit pushed to the master branch:

  • db1d823: 8320168: handle setsocktopt return values

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 20, 2023
@openjdk openjdk bot closed this Nov 20, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 20, 2023
@openjdk
Copy link

openjdk bot commented Nov 20, 2023

@djelinski Pushed as commit 9f6a4a3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@djelinski djelinski deleted the wepoll-problemlist branch November 20, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated nio nio-dev@openjdk.org
2 participants