8315969: compiler/rangechecks/TestRangeCheckHoistingScaledIV.java: make flagless

[lepestock]

A recent improvement (JDK-8314838) changed dependant VM creation in that test - we now forward given arguments via 'ProcessTools.createTestJvm()'. It has been revealed, however, that the test doesn't work well with '-Xcomp'. A bug (JDK-8316124) has been filed.

I suggest to temporarily make test 'vm.flagless' to allow for running the test in CI. As soon as JDK-8316124 is fixed, we'll remove that limitation.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8315969: compiler/rangechecks/TestRangeCheckHoistingScaledIV.java: make flagless (Bug - P4)

Reviewers

• Tobias Hartmann (@TobiHartmann - Reviewer)
• Christian Hagedorn (@chhagedorn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16746/head:pull/16746
$ git checkout pull/16746

Update a local copy of the PR:
$ git checkout pull/16746
$ git pull https://git.openjdk.org/jdk.git pull/16746/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16746

View PR using the GUI difftool:
$ git pr show -t 16746

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16746.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back enikitin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lepestock The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (a6f7aa62)
• 00: Full (532347a0)

[TobiHartmann]

Looks good to me. Please add a comment to JDK-8316124 to keep track of removing the limitation.

[openjdk]

@lepestock This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315969: compiler/rangechecks/TestRangeCheckHoistingScaledIV.java: make flagless

Reviewed-by: thartmann, chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• 839dd65: 8319244: implement JVMTI handshakes support for virtual threads
• 46e4028: 8316592: RISC-V: implement poly1305 intrinsic
• 3544d2d: 8319784: VM crash during heap dump after JDK-8287061
• 303757b: 8319879: Stress mode to randomize incremental inlining decision

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TobiHartmann, @chhagedorn) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[chhagedorn]

Looks good to me, too.

[lepestock]

/integrate

[openjdk]

@lepestock
Your change (at version a6f7aa6) is now ready to be sponsored by a Committer.

[lepestock]

Looks good to me. Please add a comment to JDK-8316124 to keep track of removing the limitation.

Raised the JDK-8320495.

[TobiHartmann]

/sponsor

[openjdk]

Going to push as commit 9598ff8.
Since your change was applied there have been 11 commits pushed to the master branch:

• 53eb6f1: 8187591: -Werror turns incubator module warning to an error
• 570dffb: 8310807: java/nio/channels/DatagramChannel/Connect.java timed out
• 21a59b9: 8282726: java/net/vthread/BlockingSocketOps.java timeout/hang intermittently on Windows
• 9232070: 8318480: Obsolete UseCounterDecay and remove CounterDecayMinIntervalLength
• e055fae: 8264425: Update building.md on non-English locales on Windows
• c4aee66: 8320222: Wrong bytecode accepted, and StackMap table generated
• 604d29a: 8304446: javap --system flag doesn't override system APIs
• 839dd65: 8319244: implement JVMTI handshakes support for virtual threads
• 46e4028: 8316592: RISC-V: implement poly1305 intrinsic
• 3544d2d: 8319784: VM crash during heap dump after JDK-8287061
• ... and 1 more: https://git.openjdk.org/jdk/compare/099a8f5b2f924fddd43ff72f3f7c6f34b6c15b0f...master

Your commit was automatically rebased without conflicts.

[openjdk]

@TobiHartmann @lepestock Pushed as commit 9598ff8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.