Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8320335: Deprecate RegisterFinalizersAtInit option and code #16747

Closed
wants to merge 1 commit into from

Conversation

DanHeidinga
Copy link
Contributor

@DanHeidinga DanHeidinga commented Nov 20, 2023

Deprecate the -XX:[+-]RegisterFinalizersAtInit option in JDK22. Goal is complete removal by JDK24.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8320409 to be approved

Issues

  • JDK-8320335: Deprecate RegisterFinalizersAtInit option and code (Enhancement - P4)
  • JDK-8320409: Deprecate RegisterFinalizersAtInit option and code (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16747/head:pull/16747
$ git checkout pull/16747

Update a local copy of the PR:
$ git checkout pull/16747
$ git pull https://git.openjdk.org/jdk.git pull/16747/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16747

View PR using the GUI difftool:
$ git pr show -t 16747

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16747.diff

Webrev

Link to Webrev Comment

Deprecate the -XX:[+-]RegisterFinalizersAtInit option in JDK22.
Goal is complete removal by JDK24.
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 20, 2023

👋 Welcome back heidinga! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added csr Pull request needs approved CSR before integration rfr Pull request is ready for review labels Nov 20, 2023
@openjdk
Copy link

openjdk bot commented Nov 20, 2023

@DanHeidinga The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Nov 20, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 20, 2023

Webrevs

Copy link
Contributor

@fisk fisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@openjdk
Copy link

openjdk bot commented Nov 21, 2023

@DanHeidinga This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8320335: Deprecate `RegisterFinalizersAtInit` option and code

Reviewed-by: eosterlund, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 210 new commits pushed to the master branch:

  • 9598ff8: 8315969: compiler/rangechecks/TestRangeCheckHoistingScaledIV.java: make flagless
  • 53eb6f1: 8187591: -Werror turns incubator module warning to an error
  • 570dffb: 8310807: java/nio/channels/DatagramChannel/Connect.java timed out
  • 21a59b9: 8282726: java/net/vthread/BlockingSocketOps.java timeout/hang intermittently on Windows
  • 9232070: 8318480: Obsolete UseCounterDecay and remove CounterDecayMinIntervalLength
  • e055fae: 8264425: Update building.md on non-English locales on Windows
  • c4aee66: 8320222: Wrong bytecode accepted, and StackMap table generated
  • 604d29a: 8304446: javap --system flag doesn't override system APIs
  • 839dd65: 8319244: implement JVMTI handshakes support for virtual threads
  • 46e4028: 8316592: RISC-V: implement poly1305 intrinsic
  • ... and 200 more: https://git.openjdk.org/jdk/compare/c788160f8acea7b58b54ad857b601bb7ffb53f8e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@fisk, @dholmes-ora) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed csr Pull request needs approved CSR before integration labels Nov 21, 2023
@DanHeidinga
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 21, 2023
@openjdk
Copy link

openjdk bot commented Nov 21, 2023

@DanHeidinga
Your change (at version 180df75) is now ready to be sponsored by a Committer.

@dholmes-ora
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 22, 2023

Going to push as commit 2c31ca5.
Since your change was applied there have been 219 commits pushed to the master branch:

  • b3616c9: 8320131: Zero build fails on macOS after JDK-8254693
  • d1af748: 8309067: gtest/AsyncLogGtest.java fails again in stderrOutput_vm
  • e47cf61: 8074211: javax.sound.midi: Error with send System Exclusive messages of different length
  • 6d82436: 8320278: ARM32 build is broken after JDK-8301997
  • f69e665: 8318364: Add an FFM-based implementation of harfbuzz OpenType layout
  • 1c0bd81: 8319124: Update XML Security for Java to 3.0.3
  • 61d81d6: 8317742: ISO Standard Date Format implementation consistency on DateTimeFormatter and String.format
  • c4aba87: 8320272: Make method_entry_barrier address shared
  • 9311749: 8320526: Use title case in building.md
  • 9598ff8: 8315969: compiler/rangechecks/TestRangeCheckHoistingScaledIV.java: make flagless
  • ... and 209 more: https://git.openjdk.org/jdk/compare/c788160f8acea7b58b54ad857b601bb7ffb53f8e...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 22, 2023
@openjdk openjdk bot closed this Nov 22, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 22, 2023
@openjdk
Copy link

openjdk bot commented Nov 22, 2023

@dholmes-ora @DanHeidinga Pushed as commit 2c31ca5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@DanHeidinga DanHeidinga deleted the JDK-8320335 branch November 22, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants