Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8320440: Implementation of Structured Concurrency (Second Preview) #16748

Closed
wants to merge 1 commit into from

Conversation

AlanBateman
Copy link
Contributor

@AlanBateman AlanBateman commented Nov 20, 2023

This API is sitting out JDK 22, meaning no API/implementation changes in this PR. We expect this API to do a third preview in JDK 23 with some API changes.

So for now, we just need to bump JEP number/title that shows up in the preview section of the javadoc.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8320440: Implementation of Structured Concurrency (Second Preview) (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16748/head:pull/16748
$ git checkout pull/16748

Update a local copy of the PR:
$ git checkout pull/16748
$ git pull https://git.openjdk.org/jdk.git pull/16748/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16748

View PR using the GUI difftool:
$ git pr show -t 16748

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16748.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 20, 2023

👋 Welcome back alanb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 20, 2023

@AlanBateman The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Nov 20, 2023
@AlanBateman AlanBateman marked this pull request as ready for review November 24, 2023 10:33
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 24, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 24, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 24, 2023

@AlanBateman This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8320440: Implementation of Structured Concurrency (Second Preview)

Reviewed-by: iris, jpai, mchung, mcimadamore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 91 new commits pushed to the master branch:

  • 99f870c: 8320781: Fix whitespace in j.l.Double and j.u.z.ZipInputStream @snippets
  • a5ccd3b: 8267532: C2: Profile and prune untaken exception handlers
  • 464dc3d: 8319633: runtime/posixSig/TestPosixSig.java intermittent timeouts on UNIX
  • efc3922: 8319048: Monitor deflation unlink phase prolongs time to safepoint
  • debf0ec: 8313355: javax/management/remote/mandatory/notif/ListenerScaleTest.java failed with "Exception: Failed: ratio=792.2791601423487"
  • 20aae3c: 8320533: Adjust capstone integration for v6 changes
  • 0678253: 8320602: Lock contention in SchemaDVFactory.getInstance()
  • f1a24f6: 8318599: HttpURLConnection cache issues leading to crashes in JGSS w/ native GSS introduced by 8303809
  • 7848ed7: 8301856: Generated .spec file for RPM installers uninstalls desktop launcher on update
  • 726f854: 8320706: RuntimePackageTest.testUsrInstallDir test fails on Linux
  • ... and 81 more: https://git.openjdk.org/jdk/compare/2b4e99140a315d3da765b2edb031b38725a05f1c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 24, 2023
Copy link
Member

@jaikiran jaikiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me.

@AlanBateman
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 2, 2023

Going to push as commit 5dee2a3.
Since your change was applied there have been 180 commits pushed to the master branch:

  • 6f7bb79: 8320931: [REDO] dsymutil command leaves around temporary directories
  • 8be3e39: 8320129: "top" command during jtreg failure handler does not display CPU usage on OSX
  • 2f299e4: 8321182: SourceExample.SOURCE_14 comment should refer to 'switch expressions' instead of 'text blocks'
  • 3a09a05: 8313722: JFR: Avoid unnecessary calls to Events.from(Recording)
  • 42af8ce: 8308614: Enabling JVMTI ClassLoad event slows down vthread creation by factor 10
  • 1839433: 8320941: Discuss receiver type handling
  • 92f7e51: 8312098: Update man page for javadoc
  • f6be7fd: 8321059: Unneeded array assignments in MergeCollation and CompactByteArray
  • d568562: 8320798: Console read line with zero out should zero out underlying buffer
  • 3087e14: 8320807: [PPC64][ZGC] C1 generates wrong code for atomics
  • ... and 170 more: https://git.openjdk.org/jdk/compare/2b4e99140a315d3da765b2edb031b38725a05f1c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 2, 2023
@openjdk openjdk bot closed this Dec 2, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 2, 2023
@openjdk
Copy link

openjdk bot commented Dec 2, 2023

@AlanBateman Pushed as commit 5dee2a3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

5 participants