Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8320278: ARM32 build is broken after JDK-8301997 #16749

Closed
wants to merge 5 commits into from

Conversation

matias9927
Copy link
Contributor

@matias9927 matias9927 commented Nov 20, 2023

JDK-8301997 changed the handling of constant pool cache entries for methods and fully removed the ConstantPoolCacheEntry class. This commit included changes to the interpreters for all supported platforms except ARM32, and its omission resulted in a GHA failure. This patch intends to introduce an ARM32 port that reflects the code changes to the included platforms so the ARM32 code can build and thus pass testing. Verified with tier 1-5 tests on Oracle platforms but not ARM32.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8320278: ARM32 build is broken after JDK-8301997 (Bug - P2)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16749/head:pull/16749
$ git checkout pull/16749

Update a local copy of the PR:
$ git checkout pull/16749
$ git pull https://git.openjdk.org/jdk.git pull/16749/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16749

View PR using the GUI difftool:
$ git pr show -t 16749

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16749.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 20, 2023

👋 Welcome back matsaave! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 20, 2023

@matias9927 The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Nov 20, 2023
@matias9927 matias9927 marked this pull request as ready for review November 20, 2023 21:44
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 20, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 20, 2023

Webrevs

Copy link
Contributor

@coleenp coleenp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. This should help the arm32 porters get started and fix the compilation errors. I think in the description, you meant to say you ran tier1-4 on Oracle platforms not arm32.

src/hotspot/cpu/arm/templateTable_arm.cpp Show resolved Hide resolved
@openjdk
Copy link

openjdk bot commented Nov 20, 2023

@matias9927 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8320278: ARM32 build is broken after JDK-8301997

Reviewed-by: coleenp, stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 20, 2023
Copy link
Member

@tstuefe tstuefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for fixing.

@matias9927
Copy link
Contributor Author

Thanks for the reviews @coleenp and @tstuefe!
/integrate

@openjdk
Copy link

openjdk bot commented Nov 21, 2023

Going to push as commit 6d82436.
Since your change was applied there have been 5 commits pushed to the master branch:

  • f69e665: 8318364: Add an FFM-based implementation of harfbuzz OpenType layout
  • 1c0bd81: 8319124: Update XML Security for Java to 3.0.3
  • 61d81d6: 8317742: ISO Standard Date Format implementation consistency on DateTimeFormatter and String.format
  • c4aba87: 8320272: Make method_entry_barrier address shared
  • 9311749: 8320526: Use title case in building.md

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 21, 2023
@openjdk openjdk bot closed this Nov 21, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 21, 2023
@openjdk
Copy link

openjdk bot commented Nov 21, 2023

@matias9927 Pushed as commit 6d82436.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
3 participants