Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8257539: tools/jpackage/windows/WinL10nTest.java unpack.bat failed with Exit code: 1618 #1676

Closed
wants to merge 19 commits into from

Conversation

andyherrick
Copy link

@andyherrick andyherrick commented Dec 7, 2020

increase retries and timeout increasing in runMsiexecWithRetries


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8257539: tools/jpackage/windows/WinL10nTest.java unpack.bat failed with Exit code: 1618

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1676/head:pull/1676
$ git checkout pull/1676

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 7, 2020

👋 Welcome back herrick! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 7, 2020
@openjdk
Copy link

openjdk bot commented Dec 7, 2020

@andyherrick The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Dec 7, 2020
@mlbridge
Copy link

mlbridge bot commented Dec 7, 2020

Webrevs

@sashamatveev
Copy link
Member

sashamatveev commented Dec 8, 2020

Looks like test failed due to:
[Fatal Error] b.wxl:3:1: XML document structures must start and end within the same entity.
So, I am not sure how increased repeat will help. Do we know why it failed to parse XML?

@andyherrick
Copy link
Author

andyherrick commented Dec 8, 2020

Looks like test failed due to:
[Fatal Error] b.wxl:3:1: XML document structures must start and end within the same entity.
So, I am not sure how increased repeat will help. Do we know why it failed to parse XML?

If you scroll down from that error - you can see that that is the expected error and the return code from jpackage is asserted to be 1, and it is asserted that the resulting WinL10NTest.msi does not exist.

the @parameters for "data" cause instance of this test to be run 8 times with different args. This instances is expected to fail since allWxlFilesValid is false.
later in the log (https://mach5.us.oracle.com:10060/api/v1/results/mach5-one-jdk-16+26-1740-tier2-20201124-1335-16116386-open_test_jdk_tier2_part2-windows-x64-125-1606226621-1556/log) you can see the timeout, where unpack.bat is run three times with 3 second delay and returns 1618 each time:
13:58:30.303] TRACE: exec: Execute cmd /c .\test.3563aceb\unpacked-msi\unpack.bat; discard I/O...
[13:58:33.469] TRACE: exec: Done. Exit code: 1618
[13:58:36.492] TRACE: exec: Execute cmd /c .\test.3563aceb\unpacked-msi\unpack.bat; discard I/O...
[13:58:39.636] TRACE: exec: Done. Exit code: 1618
[13:58:42.652] TRACE: exec: Execute cmd /c .\test.3563aceb\unpacked-msi\unpack.bat; discard I/O...
[13:58:45.803] TRACE: exec: Done. Exit code: 1618
[13:58:48.832] ERROR: Expected [0]. Actual [1618]: Check command cmd /c .\test.3563aceb\unpacked-msi\unpack.bat exited with 0 code
[13:58:48.832] [ FAILED ] WinL10nTest(name=a.wxl; culture=fr, name=b.wxl; culture=fr, fr;en-us, null).test; checks=17
[13:58:48.832] [ RUN ] WinL10nTest(name=a.wxl; culture=fr, name=b.wxl; culture=it, name=c.wxl; culture=fr, name=d.wxl; culture=it, fr;it;en-us,

running unpack.bat with msiexec command in it succeed for one test instance after the expected failure, then got 1618 return on the second test instance after the expected failure with the above timeout.

dean-long and others added 18 commits Dec 8, 2020
Reviewed-by: redestad, thartmann
… signal

Reviewed-by: ihse, alanb, dcubed, erikj
…t tools/javac/diags/CheckExamples.java

Reviewed-by: jjg
…iables of trip-counted integer loops

Reviewed-by: chagedorn, kvn
Reviewed-by: dholmes, pliden, jrose, dcubed, iklam, eosterlund, tschatzl, kvn
@openjdk openjdk bot added security security-dev@openjdk.org hotspot hotspot-dev@openjdk.org build build-dev@openjdk.org compiler compiler-dev@openjdk.org labels Dec 8, 2020
@andyherrick andyherrick marked this pull request as draft Dec 8, 2020
@openjdk openjdk bot removed the rfr Pull request is ready for review label Dec 8, 2020
@andyherrick
Copy link
Author

andyherrick commented Dec 8, 2020

I converted to draft because somehow merging with master caused a mess - since is simple change in one test file I may create a new branch and new pull request cleanly again.

@magicus
Copy link
Member

magicus commented Dec 9, 2020

/label remove build

@openjdk openjdk bot removed the build build-dev@openjdk.org label Dec 9, 2020
@openjdk
Copy link

openjdk bot commented Dec 9, 2020

@magicus
The build label was successfully removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler compiler-dev@openjdk.org core-libs core-libs-dev@openjdk.org hotspot hotspot-dev@openjdk.org security security-dev@openjdk.org