Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8318490: Increase timeout for JDK tests that are close to the limit when run with libgraal #16770

Closed
wants to merge 1 commit into from

Conversation

gergo-
Copy link

@gergo- gergo- commented Nov 21, 2023

Several JDK tests take more time to run with libgraal compared to C2 and can run into timeouts. Increase the timeouts for affected tests.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8318490: Increase timeout for JDK tests that are close to the limit when run with libgraal (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16770/head:pull/16770
$ git checkout pull/16770

Update a local copy of the PR:
$ git checkout pull/16770
$ git pull https://git.openjdk.org/jdk.git pull/16770/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16770

View PR using the GUI difftool:
$ git pr show -t 16770

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16770.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 21, 2023

👋 Welcome back gbarany! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 21, 2023

@gergo- The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-compiler hotspot-compiler-dev@openjdk.org rfr Pull request is ready for review labels Nov 21, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 21, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 21, 2023

@gergo- This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8318490: Increase timeout for JDK tests that are close to the limit when run with libgraal

Reviewed-by: dnsimon, never, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 41 new commits pushed to the master branch:

  • 06d957f: 8320582: Zero: Misplaced CX8 enablement flag
  • 14193a0: 8314614: jdk/jshell/ImportTest.java failed with "InternalError: Failed remote listen"
  • 864b39a: 8320564: RISC-V: Minimal build failed after JDK-8316592
  • 2bb4b93: 8319569: Several java/util tests should be updated to accept VM flags
  • 6016536: 8314745: JFR: @StackFilter
  • aac4318: 8320577: Improve MessageHeader's toString() function to make HttpURLConnection's debug log readable
  • 572b14a: 8320536: problemlist failing serviceability/attach/ConcAttachTest.java test on macosx
  • 30462f9: 8318986: Improve GenericWaitBarrier performance
  • 407cdd4: 8320207: doclet incorrectly chooses code font for a See Also link
  • 1629a90: 8320331: G1 Full GC Heap verification relies on metadata not reset before verification
  • ... and 31 more: https://git.openjdk.org/jdk/compare/839dd653663867f770fbe4af0a57468675eb12db...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dougxc, @tkrodriguez, @TobiHartmann) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 21, 2023
Copy link
Contributor

@tkrodriguez tkrodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok to me.

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. Do we know why these tests take longer to execute with libgraal? Is it due to higher compilation time?

@gergo-
Copy link
Author

gergo- commented Nov 23, 2023

Yes, these timeouts happen occasionally with -Xcomp due to higher compilation time than with C2. We will gradually improve this. Thanks for the reviews!

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 23, 2023
@openjdk
Copy link

openjdk bot commented Nov 23, 2023

@gergo-
Your change (at version 5b1b826) is now ready to be sponsored by a Committer.

@tkrodriguez
Copy link
Contributor

Yes as @gergo- says, our inlining policy isn't well tuned for the Xcomp case so it can produce large graphs which hurts compile time. We've retuned a little bit which helped many test. We want to tune it further without nerfing it but that won't happen until all the real bugs are addressed. We could revert these timeout changes if we make a good dent in the compile time.

@tkrodriguez
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 23, 2023

Going to push as commit 6f26311.
Since your change was applied there have been 49 commits pushed to the master branch:

  • cb95e39: 8224261: JProgressBar always with border painted around it
  • 6d79e0a: 8318159: RISC-V: Improve itable_stub
  • 06f040b: 8320645: DocLint should use javax.lang.model to detect default constructors
  • beaa79c: 8320663: Fix C syntax in LIB_SETUP_HSDIS_BINUTILS
  • 3787ff8: 8319700: [AArch64] C2 compilation fails with "Field too big for insn"
  • 99b9cb0: 8320586: update manual test/jdk/TEST.groups
  • 8db7bad: 8319813: Remove upper limit on number of compiler phases in phasetype.hpp
  • c49fb4f: 8320403: C2: PrintIdeal is no longer dumped to tty when xtty is set
  • 06d957f: 8320582: Zero: Misplaced CX8 enablement flag
  • 14193a0: 8314614: jdk/jshell/ImportTest.java failed with "InternalError: Failed remote listen"
  • ... and 39 more: https://git.openjdk.org/jdk/compare/839dd653663867f770fbe4af0a57468675eb12db...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 23, 2023
@openjdk openjdk bot closed this Nov 23, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 23, 2023
@openjdk
Copy link

openjdk bot commented Nov 23, 2023

@tkrodriguez @gergo- Pushed as commit 6f26311.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
4 participants